All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: matthew.brost@intel.com, thomas.hellstrom@linux.intel.com
Cc: dri-devel@lists.freedesktop.org
Subject: [PATCH 5/8] drm/vmwgfx: partially revert "Adapt validation code for reference-free lookups"
Date: Tue, 23 Jul 2024 14:17:47 +0200	[thread overview]
Message-ID: <20240723121750.2086-5-christian.koenig@amd.com> (raw)
In-Reply-To: <20240723121750.2086-1-christian.koenig@amd.com>

This reverts commit 64ad2abfe9a628ce79859d072704bd1ef7682044.

To me it looks like this functionality was never actually used. At least
I can't find any protection in vmw_bo_free().

Signed-off-by: Christian König <christian.koenig@amd.com>
Cc: Zack Rusin <zack.rusin@broadcom.com>
Cc: Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>
---
 drivers/gpu/drm/vmwgfx/vmwgfx_validation.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_validation.c b/drivers/gpu/drm/vmwgfx/vmwgfx_validation.c
index e7625b3f71e0..e11837e484aa 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_validation.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_validation.c
@@ -262,7 +262,8 @@ int vmw_validation_add_bo(struct vmw_validation_context *ctx,
 				bo_node->hash.key);
 		}
 		val_buf = &bo_node->base;
-		val_buf->bo = ttm_bo_get_unless_zero(&vbo->tbo);
+		vmw_bo_reference(vbo);
+		val_buf->bo = &vbo->tbo;
 		if (!val_buf->bo)
 			return -ESRCH;
 		val_buf->num_shared = 0;
@@ -656,7 +657,7 @@ void vmw_validation_unref_lists(struct vmw_validation_context *ctx)
 	struct vmw_validation_res_node *val;
 
 	list_for_each_entry(entry, &ctx->bo_list, base.head) {
-		ttm_bo_put(entry->base.bo);
+		drm_gem_object_put(&entry->base.bo->base);
 		entry->base.bo = NULL;
 	}
 
-- 
2.34.1


  parent reply	other threads:[~2024-07-23 12:18 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-23 12:17 [PATCH 1/8] drm/amdgpu: use GEM references instead of TTMs Christian König
2024-07-23 12:17 ` [PATCH 2/8] drm/radeon: " Christian König
2024-07-25 12:02   ` Daniel Vetter
2024-07-23 12:17 ` [PATCH 3/8] drm/loongson: " Christian König
2024-07-25 12:03   ` Daniel Vetter
2024-07-23 12:17 ` [PATCH 4/8] drm/vmwgfx: " Christian König
2024-07-25 12:16   ` Daniel Vetter
2024-07-23 12:17 ` Christian König [this message]
2024-07-25 12:34   ` [PATCH 5/8] drm/vmwgfx: partially revert "Adapt validation code for reference-free lookups" Daniel Vetter
2024-08-27 10:03   ` Thomas Hellström
2024-07-23 12:17 ` [PATCH 6/8] drm/ttm: revert "Export ttm_bo_get_unless_zero()" Christian König
2024-07-25 12:36   ` Daniel Vetter
2024-07-25 13:19   ` Danilo Krummrich
2024-07-23 12:17 ` [PATCH 7/8] drm/ttm: use GEM references for VM mappings Christian König
2024-07-23 12:17 ` [PATCH 8/8] drm/ttm: make ttm_bo_get internal Christian König
2024-07-25 12:01 ` [PATCH 1/8] drm/amdgpu: use GEM references instead of TTMs Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240723121750.2086-5-christian.koenig@amd.com \
    --to=ckoenig.leichtzumerken@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=matthew.brost@intel.com \
    --cc=thomas.hellstrom@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.