From: Kees Cook <kees@kernel.org>
To: kernel test robot <oliver.sang@intel.com>
Cc: Andrey Konovalov <andreyknvl@gmail.com>,
oe-lkp@lists.linux.dev, lkp@intel.com,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Erhard Furtner <erhard_f@mailbox.org>,
Nico Pache <npache@redhat.com>, Marco Elver <elver@google.com>,
Alexander Potapenko <glider@google.com>,
Andrey Ryabinin <ryabinin.a.a@gmail.com>,
Daniel Axtens <dja@axtens.net>,
Dmitry Vyukov <dvyukov@google.com>,
linux-hardening@vger.kernel.org
Subject: Re: [linus:master] [kasan, fortify] 2e577732e8: BUG:KASAN:global-out-of-bounds_in_usb_copy_descriptors
Date: Tue, 23 Jul 2024 16:35:24 -0700 [thread overview]
Message-ID: <202407231617.FEB5AC3@keescook> (raw)
In-Reply-To: <202407231547.389c0ad2-oliver.sang@intel.com>
On Tue, Jul 23, 2024 at 04:51:36PM +0800, kernel test robot wrote:
> [ 25.775287][ T1] BUG: KASAN: global-out-of-bounds in usb_copy_descriptors+0x15f/0x370
> [ 25.776048][ T1] Read of size 192 at addr ffffffff90c3e4c0 by task swapper/0/1
> ...
> [ 25.777833][ T1] __asan_memcpy+0x1f/0x60
> [ 25.777833][ T1] usb_copy_descriptors+0x15f/0x370
> [ 25.777833][ T1] usb_assign_descriptors+0xad/0x410
> [ 25.777833][ T1] f_audio_bind+0xe25/0x24f0
> [ 25.785907][ T1] usb_add_function+0x192/0x4e0
> [ 25.785907][ T1] audio_do_config+0xf9/0x160
> [ 25.785907][ T1] usb_add_config+0x38/0x460
The memcpy is:
usb_copy_descriptors(struct usb_descriptor_header **src)
...
memcpy(mem, *src, (*src)->bLength);
I can't find a bLength for a struct usb_descriptor_header::bLength that is 192...
...
audio_do_config()
usb_add_function()
function->bind(config, function);
gadget/legacy/audio.c:audio_bind()
usb_add_config()
audio_do_config()
usb_add_function()
function->bind(config, function);
f_audio_bind()
usb_assign_descriptors()
usb_copy_descriptors()
Is this thing in a loop?
--
Kees Cook
prev parent reply other threads:[~2024-07-23 23:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-23 8:51 [linus:master] [kasan, fortify] 2e577732e8: BUG:KASAN:global-out-of-bounds_in_usb_copy_descriptors kernel test robot
2024-07-23 22:20 ` Andrey Konovalov
2024-07-23 23:35 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202407231617.FEB5AC3@keescook \
--to=kees@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=dja@axtens.net \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=erhard_f@mailbox.org \
--cc=glider@google.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=npache@redhat.com \
--cc=oe-lkp@lists.linux.dev \
--cc=oliver.sang@intel.com \
--cc=ryabinin.a.a@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.