From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/speex: ARM5E needs ARM mode
Date: Tue, 23 Jul 2024 22:46:55 +0200 [thread overview]
Message-ID: <20240723224655.31a4e6fb@windsurf> (raw)
In-Reply-To: <20240723153035.260929-1-fontaine.fabrice@gmail.com>
Hello Fabrice,
On Tue, 23 Jul 2024 17:30:35 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Add a dependency on ARM mode for ARM5E to fix the following build
> failure on arm926ej-s which only supports Thumb2 mode:
This cannot be true, because ARM926EJ-S does not support Thumb2 at all.
ARM926EJ-S supports only the ARM instruction set and the classic Thumb
instruction set.
Thumb 2 was introduced in ARM1156, which is an ARMv6 core.
I'm not sure what you're pointing to ARM926EJ-S this the failing
configuration at:
> Fixes:
> - http://autobuild.buildroot.org/results/1575da3a8ea2bcde7fa9885df317a12d5c36918f
This configuration builds for Cortex-M3, which only supports the Thumb2
instruction set if I understand correctly.
> @@ -18,6 +18,7 @@ config BR2_PACKAGE_SPEEX_ARM4
> config BR2_PACKAGE_SPEEX_ARM5E
> bool
> default y
> - depends on BR2_arm && !BR2_PACKAGE_SPEEX_ARM4
> + depends on BR2_arm && BR2_ARM_CPU_HAS_ARM && \
> + !BR2_PACKAGE_SPEEX_ARM4
So I do believe this change is correct, just the explanation in the
commit log isn't.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-07-23 20:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-23 15:30 [Buildroot] [PATCH 1/1] package/speex: ARM5E needs ARM mode Fabrice Fontaine
2024-07-23 20:46 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240723224655.31a4e6fb@windsurf \
--to=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.