From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Juan José Arboleda" <soyjuanarbol@gmail.com>
Cc: virtualization@lists.linux.dev
Subject: Re: [PATCH] virtio: Fix various coding style issues
Date: Wed, 24 Jul 2024 10:01:24 -0400 [thread overview]
Message-ID: <20240724100022-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <ZpromZpQ7ajhEJHB@fedora>
On Fri, Jul 19, 2024 at 05:28:41PM -0500, Juan José Arboleda wrote:
> > warnings from which tool?
>
> Hi! Thanks for taking the time to review this!
>
> >From the 'checkpatch.pl' script
>
> Regards,
> -Juan José
As a rule, we don't just tweak coding style by running checkpatch
on existing code. Makes backports harder for little gain.
Code gets tweaked naturally as someone works on it.
--
MST
next prev parent reply other threads:[~2024-07-24 14:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-19 5:46 [PATCH] virtio: Fix various coding style issues Juan José Arboleda
2024-07-19 17:48 ` Eugenio Perez Martin
2024-07-19 18:11 ` Michael S. Tsirkin
2024-07-19 22:28 ` Juan José Arboleda
2024-07-24 14:01 ` Michael S. Tsirkin [this message]
2024-07-24 17:22 ` Juan José Arboleda
2024-07-25 6:02 ` Michael S. Tsirkin
2024-07-19 22:17 ` Juan José Arboleda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240724100022-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=soyjuanarbol@gmail.com \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.