From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFFDF19B3E3 for ; Thu, 25 Jul 2024 14:11:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721916689; cv=none; b=Nv0VKI3Eq4/VncYaTV8c8juENfbYCpxr5x9W4WEQUs3C7LRGrwj3tVjIQLF6pDhHC3GGew4dGyEzFMvNUlV0PgETBQMDQ9Vlfl9Nz6C0fI3SDFPFJCRmtlGgztOZ0h/CoTWufov249CRluFIJKYGIrdt10JPcBzNyQhIzkFw15Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721916689; c=relaxed/simple; bh=o+d3VCUm+XiAK3Nsbsy5WUA3R0e+3/oHGpriSysq0og=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SBpbKyzAqIsp37TojKRa7UW9CfAHCU6OIe9/caP0YdEct0xWMEvrK26/nbEzW0n55jW+w4KiGBMhnM0ZCi7k6F1Umg3/HXWUz5DITKWGEvYcndMTknWo7l++p8p0h9OnvFH+wVMUQ/vUEXA/qd68nUmc/jbFwVazgyFWCXbP0GM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=YzJY8j85; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YzJY8j85" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721916686; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=m+7qqjfSJJedkSM0ho4FvwKX/Ww1MNIJK3ukt4D885M=; b=YzJY8j85l4na4ra40Ue4CgwoXXq0owzGJggVRUVnOZWCYB08rB6R6akZnKGgDCeuIRu210 d7AglDDFNZJB5akmOoh4YdwU2/WTw7xnqEcqo5wOJKo8m07RTSy+5WyRq7/AELqpLVkbq5 JGMCi3GOw8dDG+Zw6QW3rtmMP06lMaM= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-606-q9GqcbQyMvKiFzC5DX1MHg-1; Thu, 25 Jul 2024 10:11:25 -0400 X-MC-Unique: q9GqcbQyMvKiFzC5DX1MHg-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-427fc86aaa2so6912145e9.0 for ; Thu, 25 Jul 2024 07:11:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721916684; x=1722521484; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=m+7qqjfSJJedkSM0ho4FvwKX/Ww1MNIJK3ukt4D885M=; b=kf+Pqd9Nif8j7s4DO3MtwMomF7lJ2wfHNRPJ7GejgLRzQ460nJ8pUO7z0IG1R2o74p KC92HWTL18WNg8L0JZH1ogmvC2RtsqawgzL9ffihKVjmcDQar0+xEsEqs4nTVra9JpR3 Av7nsYaIKDfdeg+2Z0mhwivrTAdF3LfAFdLk1ve6lLcNDwLZUQRRW+PhwdJeqvB3XVND bylbv6ZOKPjdtOXBvWzuHJhnnUEkGMBcyAYDvlcxR5ts1wWWnbhAFPA3iMxR86fEoTe9 i5D7h93/3pKXsxGZQR0d0q5BHN19QiSiyMFyFstlY9Mfx4xtx3705n3MV3bddfgTjAVN XnlA== X-Forwarded-Encrypted: i=1; AJvYcCVgvVG7UB4GqoxnkivnWwk24/GsmR9cCMpWyUbbNzVFs7fv5kcQO6s7161FxeOemTp2hj4tJvFaie2s1tFn3iRSazdZWEjg+lU0 X-Gm-Message-State: AOJu0YzJgXHj7Zji5iirsxBsrgBEa0wCkm7jJh5f3HCq6N4WBxPbdvBS wNem1mFDVufCk/fTysyzuBDFNIhPfJhaOpg2k9Gn5RsCQUs+P6GaV8E/9km3ZKBH/UUk7Vg7H2x n4RyVjyxfU6dpJELg3B85snPzZAdJRGCW5kRcID5skuBRrOJQIz/S6ULhyg== X-Received: by 2002:a05:600c:138a:b0:426:6320:226a with SMTP id 5b1f17b1804b1-4280548fb4cmr18426185e9.15.1721916684227; Thu, 25 Jul 2024 07:11:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHNsRboMyhKaoJYp9kK8awnKz/IQ2dhEpvJdwFDL7IFTPJdpWaM7Aqb1Bj5iTJbBTmDrGoXmQ== X-Received: by 2002:a05:600c:138a:b0:426:6320:226a with SMTP id 5b1f17b1804b1-4280548fb4cmr18425765e9.15.1721916683628; Thu, 25 Jul 2024 07:11:23 -0700 (PDT) Received: from redhat.com ([2a02:14f:1ec:81aa:776c:8849:e578:516a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-428057a6307sm37266205e9.36.2024.07.25.07.11.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jul 2024 07:11:23 -0700 (PDT) Date: Thu, 25 Jul 2024 10:11:18 -0400 From: "Michael S. Tsirkin" To: David Woodhouse Cc: Richard Cochran , Peter Hilber , linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org, "Ridoux, Julien" , virtio-dev@lists.linux.dev, "Luu, Ryan" , "Chashper, David" , "Mohamed Abuelfotoh, Hazem" , "Christopher S . Hall" , Jason Wang , John Stultz , netdev@vger.kernel.org, Stephen Boyd , Thomas Gleixner , Xuan Zhuo , Marc Zyngier , Mark Rutland , Daniel Lezcano , Alessandro Zummo , Alexandre Belloni , qemu-devel , Simon Horman Subject: Re: [PATCH] ptp: Add vDSO-style vmclock support Message-ID: <20240725100351-mutt-send-email-mst@kernel.org> References: <14d1626bc9ddae9d8ad19d3c508538d10f5a8e44.camel@infradead.org> <20240725012730-mutt-send-email-mst@kernel.org> <7de7da1122e61f8c64bbaab04a35af93fafac454.camel@infradead.org> <20240725081502-mutt-send-email-mst@kernel.org> <20240725082828-mutt-send-email-mst@kernel.org> <20240725083215-mutt-send-email-mst@kernel.org> <98813a70f6d3377d3a9d502fd175be97334fcc87.camel@infradead.org> Precedence: bulk X-Mailing-List: linux-rtc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <98813a70f6d3377d3a9d502fd175be97334fcc87.camel@infradead.org> On Thu, Jul 25, 2024 at 02:50:50PM +0100, David Woodhouse wrote: > Even if the virtio-rtc specification were official today, and I was > able to expose it via PCI, I probably wouldn't do it that way. There's > just far more in virtio-rtc than we need; the simple shared memory > region is perfectly sufficient for most needs, and especially ours. I can't stop amazon from shipping whatever in its hypervisor, I'd just like to understand this better, if there is a use-case not addressed here then we can change virtio to address it. The rtc driver patch posted is 900 lines, yours is 700 lines, does not look like a big difference. As for using a memory region, this is valid, but maybe rtc should be changed to do exactly that? E.g. we can easily add a capability describing such a region. or put it in device config space. I mean yes, we can build a new transport for each specific need but in the end we'll get a ton of interfaces with unclear compatibility requirements. If effort is instead spent improving common interfaces, we get consistency and everyone benefits. That's why I'm trying to understand the need here. -- MST