Re: [Buildroot] [PATCH 1/1] package/s6-dns: fix uclibc build

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Dario,

On Thu, 25 Jul 2024 17:53:48 +0200
Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:

> In any case, it should be the package source code/build system's
> responsibility to pass those flags properly. Passing them in Buildroot
> is really a work-around.
> 
> I believe the C files using st_mtim should #define one of those feature
> macros before including any of the header files.

Also, to add to the complexity, s6-dns relies on skalibs, which has its
own stat.h header file which does this:

#ifndef SKALIBS_STAT_H
#define SKALIBS_STAT_H

 /*
    This header must always be paired with skalibs/bsdsnowflake.h
    (which must always come first).
    If you #include <sys/stat.h> before bsdsnowflake, the
    workaround will not work.
 */

#include <skalibs/sysdeps.h>

#include <sys/stat.h>

#if !defined(SKALIBS_HASSTATIM) && defined(SKALIBS_HASSTATIMESPEC)

#define st_atim st_atimespec
#define st_mtim st_mtimespec
#define st_ctim st_ctimespec

#endif

#endif

I guess the easiest is probably to report the bug to upstream s6-dns
developers and see what they say.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot