All of lore.kernel.org
 help / color / mirror / Atom feed
From: Damien Le Moal <dlemoal@kernel.org>
To: linux-ide@vger.kernel.org, Niklas Cassel <cassel@kernel.org>
Subject: [PATCH v6 01/11] ata: libata: Change ata_dev_knobble() to return a bool
Date: Fri, 26 Jul 2024 12:19:44 +0900	[thread overview]
Message-ID: <20240726031954.566882-2-dlemoal@kernel.org> (raw)
In-Reply-To: <20240726031954.566882-1-dlemoal@kernel.org>

Change the function ata_dev_knobble() to return a boolean instead of a
u8.

Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Igor Pylypiv <ipylypiv@google.com>
Reviewed-by: Niklas Cassel <cassel@kernel.org>
---
 drivers/ata/libata-core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index c7752dc80028..c49334e13c0b 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -2219,12 +2219,12 @@ static int ata_do_link_spd_horkage(struct ata_device *dev)
 	return 0;
 }
 
-static inline u8 ata_dev_knobble(struct ata_device *dev)
+static inline bool ata_dev_knobble(struct ata_device *dev)
 {
 	struct ata_port *ap = dev->link->ap;
 
 	if (ata_dev_blacklisted(dev) & ATA_HORKAGE_BRIDGE_OK)
-		return 0;
+		return false;
 
 	return ((ap->cbl == ATA_CBL_SATA) && (!ata_id_is_sata(dev->id)));
 }
-- 
2.45.2


  reply	other threads:[~2024-07-26  3:19 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-26  3:19 [PATCH v6 0/4] Some cleanup, renaming and horkage improvements Damien Le Moal
2024-07-26  3:19 ` Damien Le Moal [this message]
2024-07-26  3:19 ` [PATCH v6 02/11] ata: libata: Rename ata_dma_blacklisted() Damien Le Moal
2024-07-26  3:19 ` [PATCH v6 03/11] ata: libata: Use QUIRK instead of HORKAGE Damien Le Moal
2024-07-26 10:27   ` Niklas Cassel
2024-07-29 18:41   ` Igor Pylypiv
2024-07-26  3:19 ` [PATCH v6 04/11] ata: libata: Print quirks applied to devices Damien Le Moal
2024-07-26 10:47   ` Niklas Cassel
2024-07-30 10:09   ` Geert Uytterhoeven
2024-07-30 23:39     ` Damien Le Moal
2024-07-31  7:27       ` Geert Uytterhoeven
2024-07-31  9:08         ` Damien Le Moal
2024-08-01  9:07           ` Geert Uytterhoeven
2024-08-01  9:25             ` Damien Le Moal
2024-08-01 10:05               ` Geert Uytterhoeven
2024-08-01 10:08                 ` Damien Le Moal
2024-08-01 10:42                 ` Damien Le Moal
2024-08-01 15:04                   ` Geert Uytterhoeven
2024-07-26  3:19 ` [PATCH v6 05/11] ata: pata_serverworks: Do not use the term blacklist Damien Le Moal
2024-07-26 11:12   ` Niklas Cassel
2024-07-29 18:43   ` Igor Pylypiv
2024-07-26  3:19 ` [PATCH v6 06/11] ata: ahci: Rephrase comment to " Damien Le Moal
2024-07-26 10:57   ` Niklas Cassel
2024-07-29 18:43   ` Igor Pylypiv
2024-07-26  3:19 ` [PATCH v6 07/11] ata: sata_sil: Rename sil_blacklist to sil_quirks Damien Le Moal
2024-07-26 11:13   ` Niklas Cassel
2024-07-29 18:44   ` Igor Pylypiv
2024-07-26  3:19 ` [PATCH v6 08/11] ata: ata_piix: Remove useless comment in piix_init_sidpr() Damien Le Moal
2024-07-26 11:13   ` Niklas Cassel
2024-07-29 18:45   ` Igor Pylypiv
2024-07-26  3:19 ` [PATCH v6 09/11] ata: pata_cs5520: Rephrase file header comment Damien Le Moal
2024-07-26 11:13   ` Niklas Cassel
2024-07-29 18:45   ` Igor Pylypiv
2024-07-26  3:19 ` [PATCH v6 10/11] ata: pata_hpt366: Rename hpt_dma_blacklisted() Damien Le Moal
2024-07-26 11:13   ` Niklas Cassel
2024-07-29 18:46   ` Igor Pylypiv
2024-07-26  3:19 ` [PATCH v6 11/11] ata: pata_hpt37x: " Damien Le Moal
2024-07-26 11:13   ` Niklas Cassel
2024-07-29 18:47   ` Igor Pylypiv

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240726031954.566882-2-dlemoal@kernel.org \
    --to=dlemoal@kernel.org \
    --cc=cassel@kernel.org \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.