From: Al Viro <viro@zeniv.linux.org.uk>
To: cgroups@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] memcg_write_event_control(): fix a user-triggerable oops
Date: Fri, 26 Jul 2024 06:43:57 +0100 [thread overview]
Message-ID: <20240726054357.GD99483@ZenIV> (raw)
We are *not* guaranteed that anything past the terminating NUL
is mapped (let alone initialized with anything sane).
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
diff --git a/mm/memcontrol-v1.c b/mm/memcontrol-v1.c
index 2aeea4d8bf8e..417c96f2da28 100644
--- a/mm/memcontrol-v1.c
+++ b/mm/memcontrol-v1.c
@@ -1842,9 +1842,12 @@ static ssize_t memcg_write_event_control(struct kernfs_open_file *of,
buf = endp + 1;
cfd = simple_strtoul(buf, &endp, 10);
- if ((*endp != ' ') && (*endp != '\0'))
+ if (*endp == '\0')
+ buf = endp;
+ else if (*endp == ' ')
+ buf = endp + 1;
+ else
return -EINVAL;
- buf = endp + 1;
event = kzalloc(sizeof(*event), GFP_KERNEL);
if (!event)
next reply other threads:[~2024-07-26 5:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-26 5:43 Al Viro [this message]
2024-07-26 7:06 ` [PATCH] memcg_write_event_control(): fix a user-triggerable oops Michal Hocko
2024-07-26 7:13 ` Michal Hocko
2024-07-26 7:48 ` Al Viro
2024-07-26 7:54 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240726054357.GD99483@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=cgroups@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.