All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: mic@digikod.net, gnoack@google.com, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v4 1/5] Add landlock03 test
Date: Fri, 26 Jul 2024 13:01:39 +0200	[thread overview]
Message-ID: <20240726110139.GC1062794@pevik> (raw)
In-Reply-To: <20240725-landlock-v4-1-66f5a1c0c693@suse.com>

Hi Andrea,

...
> +static struct tst_cap dropadmin = {
> +	.action = TST_CAP_DROP,
> +	.id = CAP_SYS_ADMIN,
> +	.name = "CAP_SYS_ADMIN",
> +};
> +
> +static struct tst_cap needadmin = {
> +	.action = TST_CAP_REQ,
> +	.id = CAP_SYS_ADMIN,
> +	.name = "CAP_SYS_ADMIN",
> +};

I dared to merge this with very minor change:

+++ testcases/kernel/syscalls/landlock/landlock03.c
@@ -26,16 +26,15 @@ static int ruleset_fd = -1;
 static int ruleset_invalid = -1;
 static int file_fd = -1;
 
+#define ID_NAME(x) .id = x, .name = #x
 static struct tst_cap dropadmin = {
 	.action = TST_CAP_DROP,
-	.id = CAP_SYS_ADMIN,
-	.name = "CAP_SYS_ADMIN",
+	ID_NAME(CAP_SYS_ADMIN),
 };
 
 static struct tst_cap needadmin = {
 	.action = TST_CAP_REQ,
-	.id = CAP_SYS_ADMIN,
-	.name = "CAP_SYS_ADMIN",
+	ID_NAME(CAP_SYS_ADMIN),
 };
 
 static struct tcase {

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2024-07-26 11:02 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-25  9:23 [LTP] [PATCH v4 0/5] landlock testing suite Andrea Cervesato
2024-07-25  9:23 ` [LTP] [PATCH v4 1/5] Add landlock03 test Andrea Cervesato
2024-07-26 11:01   ` Petr Vorel [this message]
2024-07-26 11:44     ` Andrea Cervesato via ltp
2024-07-25  9:23 ` [LTP] [PATCH v4 2/5] Add CAP_MKNOD fallback in lapi/capability.h Andrea Cervesato
2024-07-26 13:11   ` Petr Vorel
2024-07-25  9:23 ` [LTP] [PATCH v4 3/5] Add landlock04 test Andrea Cervesato
2024-07-26 13:06   ` Petr Vorel
2024-07-26 16:31   ` Petr Vorel
2024-07-25  9:23 ` [LTP] [PATCH v4 4/5] Add landlock05 test Andrea Cervesato
2024-07-25  9:23 ` [LTP] [PATCH v4 5/5] Add landlock06 test Andrea Cervesato
2024-07-26 13:24   ` Petr Vorel
2024-07-26 13:51     ` Mickaël Salaün
2024-07-26 14:32       ` Petr Vorel
2024-07-26 16:16         ` Petr Vorel
2024-07-26 16:21     ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240726110139.GC1062794@pevik \
    --to=pvorel@suse.cz \
    --cc=andrea.cervesato@suse.de \
    --cc=gnoack@google.com \
    --cc=ltp@lists.linux.it \
    --cc=mic@digikod.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.