Re: [PATCH v4 07/29] mbedtls: add digest shim layer for MbedTLS

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1400 bytes --]

On Fri, Jul 26, 2024 at 01:18:57PM +0300, Ilias Apalodimas wrote:
> Hi Raymond
> 
> [...]
> 
> >
> > +if MBEDTLS_LIB_CRYPTO
> > +
> > +config SHA1_MBEDTLS
> > +       bool "Enable SHA1 support with MbedTLS crypto library"
> > +       depends on MBEDTLS_LIB_CRYPTO && SHA1
> > +       help
> > +         This option enables support of hashing using SHA1 algorithm
> > +         with MbedTLS crypto library.
> > +
> > +config SHA256_MBEDTLS
> > +       bool "Enable SHA256 support with MbedTLS crypto library"
> > +       depends on MBEDTLS_LIB_CRYPTO && SHA256
> > +       help
> > +         This option enables support of hashing using SHA256 algorithm
> > +         with MbedTLS crypto library.
> > +
> > +config SHA512_MBEDTLS
> > +       bool "Enable SHA512 support with MbedTLS crypto library"
> > +       depends on MBEDTLS_LIB_CRYPTO && SHA512
> > +       default y if TI_SECURE_DEVICE && FIT_SIGNATURE
> 
> I don't like this default 'y' for 'ti secure devices'.  This is a
> board specific option. I think it should be defined on the defconfig
> of those boards instead.

This follows the current symbols which are this way because it's
basically for all ARCH_K3 platforms, and unlike the Linux Kernel, I'm
happy about seeing default y if ... in the Kconfig files for things
where there's some, but not much, choice in the matter on a given SoC.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]