Re: [PATCH] libbtrfsutil: python: fix build on Python 3.13

[David Sterba <dsterba@suse.cz>]

On Thu, Jul 25, 2024 at 06:37:01PM -0700, Omar Sandoval wrote:
> On Thu, Jul 25, 2024 at 09:29:44PM -0400, Neal Gompa wrote:
> > On Thu, Jul 25, 2024 at 9:12 PM David Sterba <dsterba@suse.cz> wrote:
> > >
> > > On Thu, Jul 25, 2024 at 04:28:35PM -0700, Omar Sandoval wrote:
> > > > From: Omar Sandoval <osandov@fb.com>
> > > >
> > > > Python 3.13, currently in beta, removed the internal
> > > > _PyObject_LookupSpecial function. The libbtrfsutil Python bindings use
> > > > it in the path_converter() function because it was based on internal
> > > > path_converter() function in CPython [1]. This is causing build failures
> > > > on Fedora Rawhide [2] and Gentoo [3]. Replace path_converter() with a
> > > > version that only uses public functions based on the one in drgn [4].
> > > >
> > > > 1: https://github.com/python/cpython/blob/d9efa45d7457b0dfea467bb1c2d22c69056ffc73/Modules/posixmodule.c#L1253
> > > > 2: https://bugzilla.redhat.com/show_bug.cgi?id=2245650
> > > > 3: https://github.com/kdave/btrfs-progs/issues/838
> > > > 4: https://github.com/osandov/drgn/blob/9ad29fd86499eb32847473e928b6540872d3d59a/libdrgn/python/util.c#L81
> > > >
> > > > Reported-by: Neal Gompa <neal@gompa.dev>
> > > > Reported-by: Sam James <sam@gentoo.org>
> > > > Signed-off-by: Omar Sandoval <osandov@fb.com>
> > >
> > > Thanks, this is more convoluted than I expected. Does this work on other
> > > python versions, like 3.8 and above? I'd have to check what's the lowest
> > > expected python version derived from the base line for distro support so
> > > 3.6 is just a guess.
> > 
> > Well, I can't build it on AlmaLinux 8 with Python 3.6 because
> > libgcrypt is too old, but it builds and works fine on CentOS Stream 9
> > (which has Python 3.9).
> 
> Yup, this works for drgn on Python 3.6-3.13.

Also confirmed by the CI test images, the lowest base is Centos 7 with
3.6.