From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B8CB1C3DA49 for ; Fri, 26 Jul 2024 17:28:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 5716860B5F; Fri, 26 Jul 2024 17:28:32 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id gTwABs7ZLPir; Fri, 26 Jul 2024 17:28:31 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org A9DB960B64 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1722014911; bh=idkwd2xGDVfwe8gE2CdY7SyWZVgWG/zo1GilwY2J9FE=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=ZY/q+JXD2VAjtcmWsLKgKMkGfIP0E7AqL3Kf3h9tpPkcZ2dFu9+cTrF+I7uhrFH+Z oGJT/l72IVF27CLUfyyeTgripx59ZFxxCPQmJ5xwhuF+u1AjnmiYFlfRq7kwlPgoWw EQYe9jVVCOjhOmcuTSPt779hZMtJJ9DxscBwVlTJiB38VMmd48nqWZBR+qbSqOxTqI ujntQY82GIDb76rz9QJo8Kzu5aRBJv/joco/+DbCLsLebpk8DbU1ge+Cnym7t4tVkY z1RzcRjHk4LRW6qRg+oTrpaH+n87ulg96GlZ72JsjIvGVHOnJrXX2v5dJIGyRI2n2g z5t3ZB62MP+Pw== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id A9DB960B64; Fri, 26 Jul 2024 17:28:31 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id F30011BF298 for ; Fri, 26 Jul 2024 17:28:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id DC6A5405F6 for ; Fri, 26 Jul 2024 17:28:29 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id XsPBU8_PGvAB for ; Fri, 26 Jul 2024 17:28:29 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org EDECC40118 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org EDECC40118 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp2.osuosl.org (Postfix) with ESMTPS id EDECC40118 for ; Fri, 26 Jul 2024 17:28:28 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id BAE9161671; Fri, 26 Jul 2024 17:28:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A435C32782; Fri, 26 Jul 2024 17:28:26 +0000 (UTC) Date: Fri, 26 Jul 2024 18:28:23 +0100 From: Simon Horman To: Karol Kolacinski Message-ID: <20240726172823.GA1699125@kernel.org> References: <20240726113631.200083-6-karol.kolacinski@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240726113631.200083-6-karol.kolacinski@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722014907; bh=LWnLwuV8oe2vBX2TVbJ2qUu/Jv8nP26LMaZlcXzTRf0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IwgILJXCbWuFD9NP18tPLnp5RjlTvAtCiR7IiyCPYvI5hdGqSyAPUMHM8o2wfy4ym 4auXvHsIgdcBeJXR8yDzlgsN4eRsLc49uwDV0IO7ZTlcpBEKQtxpN/ZHQWZa9cbhH0 sk89UpUp0M6GRKGUjHOBMWdgNoHYRHU/mLYnB2AnFV1NDxlRa9xAGcqg0L/OzfJQX+ /shWJFeDi5Htq3qeTlzmqZXd7Fgow3Mvd5Ys0Yy+zYA5GevEtNbF8mup0l6G5ci3gr LkGRfb5txbLmwdVk9xL/mtTdC5U/uu1bU4CEPmcyv6EnTLxyU0SvQRSY05pDNZ+MZb vbnB9IJ2XogIw== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=none dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=IwgILJXC Subject: Re: [Intel-wired-lan] [PATCH v4 iwl-next 0/4] ice: Implement PTP support for E830 devices X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, anthony.l.nguyen@intel.com, intel-wired-lan@lists.osuosl.org, przemyslaw.kitszel@intel.com Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Fri, Jul 26, 2024 at 01:34:42PM +0200, Karol Kolacinski wrote: > Add specific functions and definitions for E830 devices to enable > PTP support. > Refactor processing of timestamping interrupt and cross timestamp > to avoid code redundancy. > > Jacob Keller (1): > ice: combine cross timestamp functions for E82x and E830 > > Karol Kolacinski (2): > ice: Process TSYN IRQ in a separate function > ice: Add timestamp ready bitmap for E830 products > > Michal Michalik (1): > ice: Implement PTP support for E830 devices > > drivers/net/ethernet/intel/Kconfig | 10 +- > drivers/net/ethernet/intel/ice/ice_common.c | 17 +- > drivers/net/ethernet/intel/ice/ice_common.h | 1 + > .../net/ethernet/intel/ice/ice_hw_autogen.h | 12 + > drivers/net/ethernet/intel/ice/ice_main.c | 25 +- > drivers/net/ethernet/intel/ice/ice_osdep.h | 3 + > drivers/net/ethernet/intel/ice/ice_ptp.c | 356 ++++++++++++------ > drivers/net/ethernet/intel/ice/ice_ptp.h | 9 +- > drivers/net/ethernet/intel/ice/ice_ptp_hw.c | 208 +++++++++- > drivers/net/ethernet/intel/ice/ice_ptp_hw.h | 25 +- > drivers/net/ethernet/intel/ice/ice_type.h | 1 + > 11 files changed, 508 insertions(+), 159 deletions(-) > > V3 -> V4: Further kdoc fixes in "ice: Implement PTP support for > E830 devices" > V2 -> V3: Rebased and fixed kdoc in "ice: Implement PTP support for > E830 devices" > V1 -> V2: Fixed compilation issue in "ice: Implement PTP support for > E830 devices" As the recent changes are about kdoc, please consider running kernel-doc -none -Wall and ensuring no new warnings are introduced: ice_is_e830 needs a short description. And, perhaps things crossed in flight. But please address the review by Jacob and Alexander of v3. Thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF2B811C83 for ; Fri, 26 Jul 2024 17:28:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722014908; cv=none; b=It3ecwUz8soIWR8cSGCuDEojevQKifsjUVwSTTcSr9ZjBS97PUa0BKNfFf0FvXX0SPK0Asu/04bRGGkAWdJFY9UMtKf59RzpXJk/t+q3L0smAJ4DqfTShPlhf52VjyWyziVQD2gHqSxfPTuVbSFLlZTZJ6QhQt6VX4Tutg81/hg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722014908; c=relaxed/simple; bh=LWnLwuV8oe2vBX2TVbJ2qUu/Jv8nP26LMaZlcXzTRf0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SPm5NQK1qw7+ThGGBVKZGXb1xX3wK8WlpOb6JhjgdJLE3r9XZv9vw1S6ia/d/G3VH5sBDnEEUAspyAGPacXTjXno8UgYdwnLr5BNbAW66Cs/Prk/FT17r6DA9+rYUe0rzpY6CaXZn+ABEtZCCZo7Hs6YC1K4NL98Yzu8H8r3Sxs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IwgILJXC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IwgILJXC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A435C32782; Fri, 26 Jul 2024 17:28:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722014907; bh=LWnLwuV8oe2vBX2TVbJ2qUu/Jv8nP26LMaZlcXzTRf0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IwgILJXCbWuFD9NP18tPLnp5RjlTvAtCiR7IiyCPYvI5hdGqSyAPUMHM8o2wfy4ym 4auXvHsIgdcBeJXR8yDzlgsN4eRsLc49uwDV0IO7ZTlcpBEKQtxpN/ZHQWZa9cbhH0 sk89UpUp0M6GRKGUjHOBMWdgNoHYRHU/mLYnB2AnFV1NDxlRa9xAGcqg0L/OzfJQX+ /shWJFeDi5Htq3qeTlzmqZXd7Fgow3Mvd5Ys0Yy+zYA5GevEtNbF8mup0l6G5ci3gr LkGRfb5txbLmwdVk9xL/mtTdC5U/uu1bU4CEPmcyv6EnTLxyU0SvQRSY05pDNZ+MZb vbnB9IJ2XogIw== Date: Fri, 26 Jul 2024 18:28:23 +0100 From: Simon Horman To: Karol Kolacinski Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com Subject: Re: [PATCH v4 iwl-next 0/4] ice: Implement PTP support for E830 devices Message-ID: <20240726172823.GA1699125@kernel.org> References: <20240726113631.200083-6-karol.kolacinski@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240726113631.200083-6-karol.kolacinski@intel.com> On Fri, Jul 26, 2024 at 01:34:42PM +0200, Karol Kolacinski wrote: > Add specific functions and definitions for E830 devices to enable > PTP support. > Refactor processing of timestamping interrupt and cross timestamp > to avoid code redundancy. > > Jacob Keller (1): > ice: combine cross timestamp functions for E82x and E830 > > Karol Kolacinski (2): > ice: Process TSYN IRQ in a separate function > ice: Add timestamp ready bitmap for E830 products > > Michal Michalik (1): > ice: Implement PTP support for E830 devices > > drivers/net/ethernet/intel/Kconfig | 10 +- > drivers/net/ethernet/intel/ice/ice_common.c | 17 +- > drivers/net/ethernet/intel/ice/ice_common.h | 1 + > .../net/ethernet/intel/ice/ice_hw_autogen.h | 12 + > drivers/net/ethernet/intel/ice/ice_main.c | 25 +- > drivers/net/ethernet/intel/ice/ice_osdep.h | 3 + > drivers/net/ethernet/intel/ice/ice_ptp.c | 356 ++++++++++++------ > drivers/net/ethernet/intel/ice/ice_ptp.h | 9 +- > drivers/net/ethernet/intel/ice/ice_ptp_hw.c | 208 +++++++++- > drivers/net/ethernet/intel/ice/ice_ptp_hw.h | 25 +- > drivers/net/ethernet/intel/ice/ice_type.h | 1 + > 11 files changed, 508 insertions(+), 159 deletions(-) > > V3 -> V4: Further kdoc fixes in "ice: Implement PTP support for > E830 devices" > V2 -> V3: Rebased and fixed kdoc in "ice: Implement PTP support for > E830 devices" > V1 -> V2: Fixed compilation issue in "ice: Implement PTP support for > E830 devices" As the recent changes are about kdoc, please consider running kernel-doc -none -Wall and ensuring no new warnings are introduced: ice_is_e830 needs a short description. And, perhaps things crossed in flight. But please address the review by Jacob and Alexander of v3. Thanks!