From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Shenwei Wang <shenwei.wang@nxp.com>
Cc: Peter Chen <peter.chen@kernel.org>,
Pawel Laszczak <pawell@cadence.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Roger Quadros <rogerq@kernel.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>, Frank Li <frank.li@nxp.com>,
linux-usb@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com
Subject: Re: [PATCH] usb: cdns3: imx: simplify system pm using _force_suspend/_resume
Date: Fri, 26 Jul 2024 08:55:49 +0200 [thread overview]
Message-ID: <2024072635-egging-suffix-92d5@gregkh> (raw)
In-Reply-To: <20240725212811.296307-1-shenwei.wang@nxp.com>
On Thu, Jul 25, 2024 at 04:28:11PM -0500, Shenwei Wang wrote:
> By utilizing _force_suspend and _force_resume, ensures a more consistent
> and simple approach to handling system sleep states. It also aligns the
> driver's PM behavior with the other drivers' common practices.
>
> Fixes: db3c4e366287 ("usb: cdns3: imx: Rework system PM to avoid duplicated operations")
> Reviewed-by: Frank Li <frank.li@nxp.com>
> Signed-off-by: Shenwei Wang <shenwei.wang@nxp.com>
> ---
> drivers/usb/cdns3/cdns3-imx.c | 18 +++++++-----------
> 1 file changed, 7 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/usb/cdns3/cdns3-imx.c b/drivers/usb/cdns3/cdns3-imx.c
> index 281de47e2a3b..9051cbe9d68b 100644
> --- a/drivers/usb/cdns3/cdns3-imx.c
> +++ b/drivers/usb/cdns3/cdns3-imx.c
> @@ -360,7 +360,6 @@ static int cdns_imx_suspend(struct device *dev)
> return 0;
> }
>
> -
> /* Indicate if the controller was power lost before */
> static inline bool cdns_imx_is_power_lost(struct cdns_imx *data)
> {
Unneeded change here?
next prev parent reply other threads:[~2024-07-26 6:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-25 21:28 [PATCH] usb: cdns3: imx: simplify system pm using _force_suspend/_resume Shenwei Wang
2024-07-26 6:55 ` Greg Kroah-Hartman [this message]
2024-07-26 14:35 ` [EXT] " Shenwei Wang
2024-07-26 6:56 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024072635-egging-suffix-92d5@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=festevam@gmail.com \
--cc=frank.li@nxp.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-usb@vger.kernel.org \
--cc=pawell@cadence.com \
--cc=peter.chen@kernel.org \
--cc=rogerq@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shenwei.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.