From: Jakub Kicinski <kuba@kernel.org>
To: Stanislav Fomichev <sdf@fomichev.me>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, Shuah Khan <shuah@kernel.org>,
Joe Damato <jdamato@fastly.com>, Petr Machata <petrm@nvidia.com>,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] selftests: net: ksft: support marking tests as disruptive
Date: Mon, 29 Jul 2024 19:00:13 -0700 [thread overview]
Message-ID: <20240729190013.5b0743e7@kernel.org> (raw)
In-Reply-To: <20240729221042.2700882-2-sdf@fomichev.me>
On Mon, 29 Jul 2024 15:10:42 -0700 Stanislav Fomichev wrote:
> + parser = argparse.ArgumentParser()
> + parser.add_argument('--skip-disruptive', default=False, action='store_true', help='skip tests that might be disruptive (e.g. restart the interface)')
> + global KSFT_ARGS
> + KSFT_ARGS = parser.parse_args()
We pass all other args via env exports, I think we should stick to
that, it's easier to integrate with external runners.
FWIW Mohsin is also adding VERBOSE=1 this way:
https://lore.kernel.org/all/20240715030723.1768360-1-mohsin.bashr@gmail.com/
next prev parent reply other threads:[~2024-07-30 2:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 22:10 [PATCH net-next 1/2] selftests: net-drv: exercise queue stats when the device is down Stanislav Fomichev
2024-07-29 22:10 ` [PATCH net-next 2/2] selftests: net: ksft: support marking tests as disruptive Stanislav Fomichev
2024-07-30 2:00 ` Jakub Kicinski [this message]
2024-07-30 16:20 ` Stanislav Fomichev
2024-07-30 18:13 ` Jakub Kicinski
2024-07-30 1:58 ` [PATCH net-next 1/2] selftests: net-drv: exercise queue stats when the device is down Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240729190013.5b0743e7@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jdamato@fastly.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.