Re: [Buildroot] [PATCH 1/1] package/openconnect: new package

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/openconnect: new package
Date: Mon, 29 Jul 2024 22:44:44 +0200	[thread overview]
Message-ID: <20240729224444.12110219@windsurf> (raw)
In-Reply-To: <20240728115029.1174631-1-bernd@kuhls.net>

Hello Bernd,

On Sun, 28 Jul 2024 13:50:29 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:

> diff --git a/package/openconnect/Config.in b/package/openconnect/Config.in
> new file mode 100644
> index 0000000000..502babd5b4
> --- /dev/null
> +++ b/package/openconnect/Config.in
> @@ -0,0 +1,19 @@
> +config BR2_PACKAGE_OPENCONNECT
> +	bool "openconnect"
> +	depends on BR2_PACKAGE_GNUTLS || BR2_PACKAGE_LIBOPENSSL

Instead of this, we do:

        select BR2_PACKAGE_OPENSSL if !BR2_PACKAGE_GNUTLS
        select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL if !BR2_PACKAGE_GNUTLS

in a number of other packages. I've also added a comment above the
"select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL" to explain why it is
selected.

Also, some features of OpenSSL need to be explicitly selected:

+       select BR2_PACKAGE_LIBOPENSSL_ENABLE_RC4 if !BR2_PACKAGE_GNUTLS
+       select BR2_PACKAGE_LIBOPENSSL_ENABLE_DES if !BR2_PACKAGE_GNUTLS

Basically for any package that uses libopenssl, make sure to do a test
build with all OpenSSL features disabled, to catch these issues.

Patch applied with those changes. Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot