From: Johannes Thumshirn <jth@kernel.org>
To: Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>
Cc: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Johannes Thumshirn <johannes.thumshirn@wdc.com>
Subject: [PATCH v2 1/5] btrfs: don't dump stripe-tree on lookup error
Date: Tue, 30 Jul 2024 12:33:14 +0200 [thread overview]
Message-ID: <20240730-debug-v2-1-38e6607ecba6@kernel.org> (raw)
In-Reply-To: <20240730-debug-v2-0-38e6607ecba6@kernel.org>
From: Johannes Thumshirn <johannes.thumshirn@wdc.com>
This just creates unnecessary noise and doesn't provide any insights into
debugging RAID stripe-tree related issues.
Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
---
fs/btrfs/raid-stripe-tree.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/btrfs/raid-stripe-tree.c b/fs/btrfs/raid-stripe-tree.c
index 684d4744f02d..97430918e923 100644
--- a/fs/btrfs/raid-stripe-tree.c
+++ b/fs/btrfs/raid-stripe-tree.c
@@ -284,8 +284,6 @@ int btrfs_get_raid_extent_offset(struct btrfs_fs_info *fs_info,
if (ret > 0)
ret = -ENOENT;
if (ret && ret != -EIO && !stripe->is_scrub) {
- if (IS_ENABLED(CONFIG_BTRFS_DEBUG))
- btrfs_print_tree(leaf, 1);
btrfs_err(fs_info,
"cannot find raid-stripe for logical [%llu, %llu] devid %llu, profile %s",
logical, logical + *length, stripe->dev->devid,
--
2.43.0
next prev parent reply other threads:[~2024-07-30 10:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 10:33 [PATCH v2 0/5] btrfs: fix relocation on RAID stripe-tree filesystems Johannes Thumshirn
2024-07-30 10:33 ` Johannes Thumshirn [this message]
2024-07-30 10:33 ` [PATCH v2 2/5] btrfs: rename btrfs_io_stripe::is_scrub to rst_search_commit_root Johannes Thumshirn
2024-07-30 10:33 ` [PATCH v2 3/5] btrfs: set rst_search_commit_root in case of relocation Johannes Thumshirn
2024-07-30 10:33 ` [PATCH v2 4/5] btrfs: don't readahead the relocation inode on RST Johannes Thumshirn
2024-07-30 10:33 ` [PATCH v2 5/5] btrfs: change RST lookup error message to debug Johannes Thumshirn
2024-07-30 16:56 ` [PATCH v2 0/5] btrfs: fix relocation on RAID stripe-tree filesystems Josef Bacik
2024-07-30 21:34 ` Qu Wenruo
2024-07-31 20:13 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240730-debug-v2-1-38e6607ecba6@kernel.org \
--to=jth@kernel.org \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=johannes.thumshirn@wdc.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.