From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Mayank Rana <quic_mrana@quicinc.com>
Cc: will@kernel.org, lpieralisi@kernel.org, kw@linux.com,
robh@kernel.org, bhelgaas@google.com, jingoohan1@gmail.com,
cassel@kernel.org, yoshihiro.shimoda.uh@renesas.com,
s-vadapalli@ti.com, u.kleine-koenig@pengutronix.de,
dlemoal@kernel.org, amishin@t-argos.ru, thierry.reding@gmail.com,
jonathanh@nvidia.com, Frank.Li@nxp.com,
ilpo.jarvinen@linux.intel.com, vidyas@nvidia.com,
marek.vasut+renesas@gmail.com, krzk+dt@kernel.org,
conor+dt@kernel.org, linux-pci@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
quic_ramkri@quicinc.com, quic_nkela@quicinc.com,
quic_shazhuss@quicinc.com, quic_msarkar@quicinc.com,
quic_nitegupt@quicinc.com
Subject: Re: [PATCH V2 0/7] Add power domain and MSI functionality with PCIe host generic ECAM driver
Date: Tue, 30 Jul 2024 11:04:25 +0530 [thread overview]
Message-ID: <20240730053425.GB3122@thinkpad> (raw)
In-Reply-To: <925d1eca-975f-4eec-bdf8-ca07a892361a@quicinc.com>
On Mon, Jul 29, 2024 at 10:19:45AM -0700, Mayank Rana wrote:
> Hi Bjorn / Mani
>
> Gentle ping for your review/feedback on this series.
> Thank you.
>
I was waiting for your reply for my comment [1]. Because that will have
influence on this series.
- Mani
[1] https://lore.kernel.org/linux-pci/20240724095407.GA2347@thinkpad/
> Regards,
> Mayank
>
> On 7/15/2024 11:13 AM, Mayank Rana wrote:
> > Based on previously received feedback, this patch series adds functionalities
> > with existing PCIe host generic ECAM driver (pci-host-generic.c) to get PCIe
> > host root complex functionality on Qualcomm SA8775P auto platform.
> >
> > Previously sent RFC patchset to have separate Qualcomm PCIe ECAM platform driver:
> > https://lore.kernel.org/all/d10199df-5fb3-407b-b404-a0a4d067341f@quicinc.com/T/
> >
> > 1. Interface to allow requesting firmware to manage system resources and performing
> > PCIe Link up (devicetree binding in terms of power domain and runtime PM APIs is used in driver)
> > 2. Performing D3 cold with system suspend and D0 with system resume (usage of GenPD
> > framework based power domain controls these operations)
> > 3. SA8775P is using Synopsys Designware PCIe controller which supports MSI controller.
> > This MSI functionality is used with PCIe host generic driver after splitting existing MSI
> > functionality from pcie-designware-host.c file into pcie-designware-msi.c file.
> >
> > Below architecture is used on Qualcomm SA8775P auto platform to get ECAM compliant PCIe
> > controller based functionality. Here firmware VM based PCIe driver takes care of resource
> > management and performing PCIe link related handling (D0 and D3cold). Linux VM based PCIe
> > host generic driver uses power domain to request firmware VM to perform these operations
> > using SCMI interface.
> > ----------------
> >
> >
> > ┌────────────────────────┐
> > │ │
> > ┌──────────────────────┐ │ SHARED MEMORY │ ┌──────────────────────────┐
> > │ Firmware VM │ │ │ │ Linux VM │
> > │ ┌─────────┐ │ │ │ │ ┌────────────────┐ │
> > │ │ Drivers │ ┌──────┐ │ │ │ │ │ PCIE host │ │
> > │ │ PCIE PHY◄─┤ │ │ │ ┌────────────────┐ │ │ │ generic driver│ │
> > │ │ │ │ SCMI │ │ │ │ │ │ │ │ │ │
> > │ │PCIE CTL │ │ │ ├─────────┼───► PCIE ◄───┼─────┐ │ └──┬──────────▲──┘ │
> > │ │ ├─►Server│ │ │ │ SHMEM │ │ │ │ │ │ │
> > │ │Clk, Vreg│ │ │ │ │ │ │ │ │ │ ┌──▼──────────┴──┐ │
> > │ │GPIO,GDSC│ └─▲──┬─┘ │ │ └────────────────┘ │ └──────┼────┤PCIE SCMI Inst │ │
> > │ └─────────┘ │ │ │ │ │ │ └──▲──────────┬──┘ │
> > │ │ │ │ │ │ │ │ │ │
> > └───────────────┼──┼───┘ │ │ └───────┼──────────┼───────┘
> > │ │ │ │ │ │
> > │ │ └────────────────────────┘ │ │
> > │ │ │ │
> > │ │ │ │
> > │ │ │ │
> > │ │ │IRQ │HVC
> > IRQ │ │HVC │ │
> > │ │ │ │
> > │ │ │ │
> > │ │ │ │
> > ┌─────────────────┴──▼───────────────────────────────────────────────────────────┴──────────▼──────────────┐
> > │ │
> > │ │
> > │ HYPERVISOR │
> > │ │
> > │ │
> > │ │
> > └──────────────────────────────────────────────────────────────────────────────────────────────────────────┘
> > ┌─────────────┐ ┌─────────────┐ ┌──────────┐ ┌───────────┐ ┌─────────────┐ ┌────────────┐
> > │ │ │ │ │ │ │ │ │ PCIE │ │ PCIE │
> > │ CLOCK │ │ REGULATOR │ │ GPIO │ │ GDSC │ │ PHY │ │ controller │
> > └─────────────┘ └─────────────┘ └──────────┘ └───────────┘ └─────────────┘ └────────────┘
> > ----------
> > Changes in V2:
> > - Drop new PCIe Qcom ECAM driver, and use existing PCIe designware based MSI functionality
> > - Add power domain based functionality within existing ECAM driver
> >
> > Tested:
> > - Validated NVME functionality with PCIe0 and PCIe1 on SA8775P-RIDE platform
> >
> > Mayank Rana (7):
> > PCI: dwc: Move MSI related code to separate file
> > PCI: dwc: Add msi_ops to allow DBI based MSI register access
> > PCI: dwc: Add pcie-designware-msi driver kconfig option
> > dt-bindings: PCI: host-generic-pci: Add power-domains binding
> > PCI: host-generic: Add power domain based handling for PCIe controller
> > dt-bindings: PCI: host-generic-pci: Add snps,dw-pcie-ecam-msi binding
> > PCI: host-generic: Add dwc MSI based MSI functionality
> >
> > .../devicetree/bindings/pci/host-generic-pci.yaml | 64 +++
> > drivers/pci/controller/dwc/Kconfig | 8 +
> > drivers/pci/controller/dwc/Makefile | 1 +
> > drivers/pci/controller/dwc/pci-keystone.c | 12 +-
> > drivers/pci/controller/dwc/pcie-designware-host.c | 438 ++-------------------
> > drivers/pci/controller/dwc/pcie-designware-msi.c | 413 +++++++++++++++++++
> > drivers/pci/controller/dwc/pcie-designware-msi.h | 63 +++
> > drivers/pci/controller/dwc/pcie-designware.c | 1 +
> > drivers/pci/controller/dwc/pcie-designware.h | 26 +-
> > drivers/pci/controller/dwc/pcie-rcar-gen4.c | 1 +
> > drivers/pci/controller/dwc/pcie-tegra194.c | 5 +-
> > drivers/pci/controller/pci-host-generic.c | 127 +++++-
> > 12 files changed, 723 insertions(+), 436 deletions(-)
> > create mode 100644 drivers/pci/controller/dwc/pcie-designware-msi.c
> > create mode 100644 drivers/pci/controller/dwc/pcie-designware-msi.h
> >
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2024-07-30 5:34 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-15 18:13 [PATCH V2 0/7] Add power domain and MSI functionality with PCIe host generic ECAM driver Mayank Rana
2024-07-15 18:13 ` [PATCH V2 1/7] PCI: dwc: Move MSI functionality related code to separate file Mayank Rana
2024-07-31 16:40 ` Manivannan Sadhasivam
2024-07-15 18:13 ` [PATCH V222/7] PCI: dwc: Add msi_ops to allow DBI based MSI register access Mayank Rana
2024-07-31 17:17 ` Manivannan Sadhasivam
2024-07-15 18:13 ` [PATCH V2 3/7] PCI: dwc: Add pcie-designware-msi driver related Kconfig option Mayank Rana
2024-07-15 18:39 ` Andrew Lunn
2024-07-16 0:04 ` Mayank Rana
2024-07-15 18:13 ` [PATCH V2 4/7] dt-bindings: PCI: host-generic-pci: Add power-domains related binding Mayank Rana
2024-07-16 7:25 ` Krzysztof Kozlowski
2024-07-16 21:47 ` Mayank Rana
2024-07-15 18:13 ` [PATCH V2 5/7] PCI: host-generic: Add power domain based handling for PCIe controller Mayank Rana
2024-07-15 18:13 ` [PATCH V226/7] dt-bindings: PCI: host-generic-pci: Add snps,dw-pcie-ecam-msi binding Mayank Rana
2024-07-15 19:43 ` Rob Herring (Arm)
2024-07-16 7:28 ` Krzysztof Kozlowski
2024-07-16 22:09 ` Mayank Rana
2024-07-17 6:47 ` Krzysztof Kozlowski
2024-07-17 17:20 ` Mayank Rana
2024-07-18 6:05 ` Krzysztof Kozlowski
2024-07-18 23:19 ` Mayank Rana
2024-07-20 18:30 ` Krzysztof Kozlowski
2024-07-31 17:26 ` Manivannan Sadhasivam
2024-07-15 18:13 ` [PATCH V2 7/7] PCI: host-generic: Add dwc PCIe controller based MSI controller usage Mayank Rana
2024-07-16 8:58 ` Will Deacon
2024-07-16 13:42 ` Rob Herring
2024-07-16 22:32 ` Mayank Rana
2024-07-23 22:56 ` Mayank Rana
2024-07-24 9:54 ` Manivannan Sadhasivam
2024-07-24 2:13 ` [PATCH V2 0/7] Add power domain and MSI functionality with PCIe host generic ECAM driver Dmitry Baryshkov
2024-07-24 3:58 ` Mayank Rana
2024-07-24 7:12 ` Dmitry Baryshkov
2024-07-24 13:31 ` Manivannan Sadhasivam
2024-07-24 13:34 ` Dmitry Baryshkov
2024-07-24 16:51 ` Mayank Rana
2024-07-29 17:19 ` Mayank Rana
2024-07-30 5:34 ` Manivannan Sadhasivam [this message]
2024-07-30 16:16 ` Mayank Rana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240730053425.GB3122@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=Frank.Li@nxp.com \
--cc=amishin@t-argos.ru \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlemoal@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jingoohan1@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=quic_mrana@quicinc.com \
--cc=quic_msarkar@quicinc.com \
--cc=quic_nitegupt@quicinc.com \
--cc=quic_nkela@quicinc.com \
--cc=quic_ramkri@quicinc.com \
--cc=quic_shazhuss@quicinc.com \
--cc=robh@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vidyas@nvidia.com \
--cc=will@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.