From: Leon Romanovsky <leon@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Mostafa Saleh <smostafa@google.com>,
Robin Murphy <robin.murphy@arm.com>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Easwar Hariharan <eahariha@linux.microsoft.com>,
linux-kernel@vger.kernel.org, iommu@lists.linux.dev,
Jason Gunthorpe <jgg@nvidia.com>
Subject: Re: [PATCH v2 2/2] dma: add IOMMU static calls with clear default ops
Date: Tue, 30 Jul 2024 11:16:37 +0300 [thread overview]
Message-ID: <20240730081637.GB4209@unreal> (raw)
In-Reply-To: <20240729171518.GB31388@lst.de>
On Mon, Jul 29, 2024 at 07:15:18PM +0200, Christoph Hellwig wrote:
> On Mon, Jul 29, 2024 at 12:41:12PM +0000, Mostafa Saleh wrote:
> > Just out of curiosity, is there any observed improvement from that?
> > As from my experience the DMA-IOMMU path is quite dense so it won't
> > be senstive to such micro-optimizations.
>
> We are trying to gradually fix this. Part of that is adding not even
> more indirect calls for the next generation map API. But another totally
> unrelated part is that we can compile out the dma ops entirely for
> common configs, which I really want because people are badly abusing it.
Christoph,
This is good remark, should I add this to the commit message and send v5?
v4: https://lore.kernel.org/all/cover.1721818168.git.leon@kernel.org/
Thanks
next prev parent reply other threads:[~2024-07-30 8:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-17 12:37 [PATCH v2 0/2] DMA IOMMU static calls Leon Romanovsky
2024-07-17 12:37 ` [PATCH v2 1/2] dma: call unconditionally to unmap_page and unmap_sg callbacks Leon Romanovsky
2024-07-18 3:49 ` Christoph Hellwig
2024-07-18 6:33 ` Leon Romanovsky
2024-07-17 12:37 ` [PATCH v2 2/2] dma: add IOMMU static calls with clear default ops Leon Romanovsky
2024-07-18 3:48 ` Christoph Hellwig
2024-07-18 7:04 ` Leon Romanovsky
2024-07-18 12:30 ` Christoph Hellwig
2024-07-18 13:26 ` Leon Romanovsky
2024-07-29 12:41 ` Mostafa Saleh
2024-07-29 14:07 ` Leon Romanovsky
2024-07-29 17:15 ` Christoph Hellwig
2024-07-30 8:16 ` Leon Romanovsky [this message]
2024-07-30 15:26 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240730081637.GB4209@unreal \
--to=leon@kernel.org \
--cc=eahariha@linux.microsoft.com \
--cc=hch@lst.de \
--cc=iommu@lists.linux.dev \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
--cc=smostafa@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.