From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7C8C0C3DA49 for ; Tue, 30 Jul 2024 10:23:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 30AAC8111F; Tue, 30 Jul 2024 10:23:48 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id UCocYQKjlOPD; Tue, 30 Jul 2024 10:23:47 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 80EBE81138 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1722335027; bh=ksdXwC/oJ4+sR6UJnarAWnphmNgZcZbQi7nhwMaDpfg=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=SK7svi1HGPwNsop3B52MePts3mBvpW6cblNMtl0GJ95rexjc4PJ2ddFoZKuU9u/Ry NEkwgudWzO/cSzdSX/sTw/eo8q/SrxkZRJ4o0eYgeIUqHn48ag7xNeqL/XLqonDj0p jxUVIP7JEooNfFg2ArFzsy7uliuNh13NfdS+OKvW7m8avhqSkrXQ27k12S2p1DthEu 4wXcSxJ96QIS1OJFQLA6LUKePJXuZNpAtYERPsHA262CTMUWfybOrHCBs3pOyqyjgq cROiOOn1/ld1vFzFJSEGAyMnF1apYF/JJ1aNgpfa7IaaOBKUnFA7zXuJ3fpD9XjXH0 QFAdsVizzT+sA== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 80EBE81138; Tue, 30 Jul 2024 10:23:47 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 451101BF5DA for ; Tue, 30 Jul 2024 10:23:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 3B28D4023F for ; Tue, 30 Jul 2024 10:23:45 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id aKeru5TtaOI5 for ; Tue, 30 Jul 2024 10:23:44 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 7E31D4057F DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 7E31D4057F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp2.osuosl.org (Postfix) with ESMTPS id 7E31D4057F for ; Tue, 30 Jul 2024 10:23:44 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id BB25A61C5D; Tue, 30 Jul 2024 10:23:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A61E4C32782; Tue, 30 Jul 2024 10:23:41 +0000 (UTC) Date: Tue, 30 Jul 2024 11:23:39 +0100 From: Simon Horman To: Ahmed Zaki Message-ID: <20240730102339.GW97837@kernel.org> References: <20240725220810.12748-1-ahmed.zaki@intel.com> <20240725220810.12748-11-ahmed.zaki@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240725220810.12748-11-ahmed.zaki@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722335023; bh=63xEIcvXjlR02Hfdugx6BZutPkEtvIG450jNMfawbKk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mbE3e+xpn6vyHWMeQ+uoHM97DCxhzDqPtRSeB/HzeXGjBdF082v43QB6oRPAiGxS0 UmwlGWpctecsIAKDTFpghzwHBSUbsH9Geywt5Uk+SqyT+Mvg7O79rvLZ5kdlr8Iax4 +/cqwUFyE/kJOQBh/pVOwwacUyPUxCr85iKbOeDxiNFMIo1wxP3MpvMemugtZABooz +DDgYws5CO5tJKQMIv5HWZmjO1yJjyRcFlwIR2pV0EczTKZBrvl7fV7JdyCL1RXdqO hviHGkBve7kYUkh7cTAhZm0yK7vj13aFql52YySgvezKt6QFuTFURrew8iNGG/ocb3 5sxVsp/R5Mj1g== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=none dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=mbE3e+xp Subject: Re: [Intel-wired-lan] [PATCH iwl-next v5 10/13] ice: add method to disable FDIR SWAP option X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, hkelam@marvell.com, Marcin Szycik , anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, Junfeng Guo , intel-wired-lan@lists.osuosl.org, Rafal Romanowski Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Thu, Jul 25, 2024 at 04:08:06PM -0600, Ahmed Zaki wrote: > From: Junfeng Guo > > The SWAP Flag in the FDIR Programming Descriptor doesn't work properly, > it is always set and cannot be unset (hardware bug). Thus, add a method > to effectively disable the FDIR SWAP option by setting the FDSWAP instead > of FDINSET registers. > > Reviewed-by: Marcin Szycik > Signed-off-by: Junfeng Guo > Signed-off-by: Ahmed Zaki > Tested-by: Rafal Romanowski Reviewed-by: Simon Horman From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED64C195997 for ; Tue, 30 Jul 2024 10:23:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722335024; cv=none; b=oJmaluXhUT8qmx5Va22ah4p7E901kqAMuSljts1gtd2/K5xeS4EHV1EXpuKiIyE1gigdgEQQbLEr8uM46GrfXVT26kGtG4wXKGArDOH55Cdb6U2fjClZ9Fi1RxB0WhYJrRQntJmefNyl8oRSb/Tl9vAcO0bEThVGd/NgtfEXfhg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722335024; c=relaxed/simple; bh=63xEIcvXjlR02Hfdugx6BZutPkEtvIG450jNMfawbKk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BrepVvg6G73jb7H+nHqnZ0CS2PMU8reZQNte66SwPXlFTrbaq2HQJI8w/G42hsG4fIwFFsrRphYKW/AYboeA+kXMEtfnX5FTfcxxIGRsJIvekSd4iqzSGsGFiBBurfBPgWc64u1DfN54+NEsqmfrtGULodkcPFENcj7RCIzv4L4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mbE3e+xp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mbE3e+xp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A61E4C32782; Tue, 30 Jul 2024 10:23:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722335023; bh=63xEIcvXjlR02Hfdugx6BZutPkEtvIG450jNMfawbKk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mbE3e+xpn6vyHWMeQ+uoHM97DCxhzDqPtRSeB/HzeXGjBdF082v43QB6oRPAiGxS0 UmwlGWpctecsIAKDTFpghzwHBSUbsH9Geywt5Uk+SqyT+Mvg7O79rvLZ5kdlr8Iax4 +/cqwUFyE/kJOQBh/pVOwwacUyPUxCr85iKbOeDxiNFMIo1wxP3MpvMemugtZABooz +DDgYws5CO5tJKQMIv5HWZmjO1yJjyRcFlwIR2pV0EczTKZBrvl7fV7JdyCL1RXdqO hviHGkBve7kYUkh7cTAhZm0yK7vj13aFql52YySgvezKt6QFuTFURrew8iNGG/ocb3 5sxVsp/R5Mj1g== Date: Tue, 30 Jul 2024 11:23:39 +0100 From: Simon Horman To: Ahmed Zaki Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, hkelam@marvell.com, Junfeng Guo , Marcin Szycik , Rafal Romanowski Subject: Re: [PATCH iwl-next v5 10/13] ice: add method to disable FDIR SWAP option Message-ID: <20240730102339.GW97837@kernel.org> References: <20240725220810.12748-1-ahmed.zaki@intel.com> <20240725220810.12748-11-ahmed.zaki@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240725220810.12748-11-ahmed.zaki@intel.com> On Thu, Jul 25, 2024 at 04:08:06PM -0600, Ahmed Zaki wrote: > From: Junfeng Guo > > The SWAP Flag in the FDIR Programming Descriptor doesn't work properly, > it is always set and cannot be unset (hardware bug). Thus, add a method > to effectively disable the FDIR SWAP option by setting the FDSWAP instead > of FDINSET registers. > > Reviewed-by: Marcin Szycik > Signed-off-by: Junfeng Guo > Signed-off-by: Ahmed Zaki > Tested-by: Rafal Romanowski Reviewed-by: Simon Horman