From: Christoph Hellwig <hch@lst.de>
To: Kanchan Joshi <joshi.k@samsung.com>
Cc: kbusch@kernel.org, hch@lst.de, sagi@grimberg.me,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH 1/3] nvme: remove a field from nvme_ns_head
Date: Tue, 30 Jul 2024 17:02:51 +0200 [thread overview]
Message-ID: <20240730150251.GA29099@lst.de> (raw)
In-Reply-To: <20240730103138.66714-2-joshi.k@samsung.com>
On Tue, Jul 30, 2024 at 04:01:36PM +0530, Kanchan Joshi wrote:
> pi_offset field is not required to be present in nvme_ns_head.
Maybe spell the field name out in the subject? Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2024-07-30 15:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240730103941epcas5p37930edd18b9649d4df2083151ed21022@epcas5p3.samsung.com>
2024-07-30 10:31 ` [PATCH 0/3] nvme_ns_head cleanup Kanchan Joshi
2024-07-30 10:31 ` [PATCH 1/3] nvme: remove a field from nvme_ns_head Kanchan Joshi
2024-07-30 15:02 ` Christoph Hellwig [this message]
2024-07-31 9:45 ` Sagi Grimberg
2024-07-31 15:36 ` Keith Busch
2024-07-30 10:31 ` [PATCH 2/3] nvme: change data type of lba_shift Kanchan Joshi
2024-07-30 15:03 ` Christoph Hellwig
2024-07-31 9:46 ` Sagi Grimberg
2024-07-30 10:31 ` [PATCH 3/3] nvme: reorganize nvme_ns_head fields Kanchan Joshi
2024-07-30 15:04 ` Christoph Hellwig
2024-07-31 9:46 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240730150251.GA29099@lst.de \
--to=hch@lst.de \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.