From: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: Xiao Ni <xni@redhat.com>, ncroxon@redhat.com, linux-raid@vger.kernel.org
Subject: Re: [PATCH V4 00/14] mdadm: fix coverity issues
Date: Tue, 30 Jul 2024 15:51:06 +0200 [thread overview]
Message-ID: <20240730155106.00001560@linux.intel.com> (raw)
In-Reply-To: <657cd05c-cc98-4f98-bd02-3db72089356b@molgen.mpg.de>
On Fri, 26 Jul 2024 10:01:29 +0200
Paul Menzel <pmenzel@molgen.mpg.de> wrote:
> In my opinion, naming the tool reporting the issue in the commit message
> summary is not beneficial, and I’d prefer to have more detail on the
> change in there. The tool could be named/credited in the commit message
> body.
Hmm, I didn't put a huge patience into that, I accepted similar commits from
Nigel on GH, like this one:
https://git.kernel.org/pub/scm/utils/mdadm/mdadm.git/commit/?id=1b4b73fd535a6487075e98f620454ff2e13b5240
However, he used the exact problem description reported by the tool in commit
message. This is not exactly the same style.
I may looks like hypocrite, asking for changes from Xiao now.
For that reason I'm fine with current style but I doesn't mean that I disagree
with Paul. I agree with Paul.
Xiao, let me know if you would like to rework descriptions or you would
prefer me to pick it in this form.
Mariusz
next prev parent reply other threads:[~2024-07-30 13:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-26 7:14 [PATCH V4 00/14] mdadm: fix coverity issues Xiao Ni
2024-07-26 7:14 ` [PATCH 01/14] mdadm/Grow: fix coverity issue CHECKED_RETURN Xiao Ni
2024-07-26 7:14 ` [PATCH 02/14] mdadm/Grow: fix coverity issue RESOURCE_LEAK Xiao Ni
2024-07-26 7:14 ` [PATCH 03/14] mdadm/Grow: fix coverity issue STRING_OVERFLOW Xiao Ni
2024-07-26 7:14 ` [PATCH 04/14] mdadm/Incremental: fix coverity issues Xiao Ni
2024-07-26 7:14 ` [PATCH 05/14] mdadm/mdmon: fix coverity issue CHECKED_RETURN Xiao Ni
2024-07-26 7:14 ` [PATCH 06/14] mdadm/mdmon: fix coverity issue RESOURCE_LEAK Xiao Ni
2024-07-26 7:14 ` [PATCH 07/14] mdadm/mdopen: fix coverity issue CHECKED_RETURN Xiao Ni
2024-07-26 7:14 ` [PATCH 08/14] mdadm/mdopen: fix coverity issue STRING_OVERFLOW Xiao Ni
2024-07-26 7:14 ` [PATCH 09/14] mdadm/mdstat: fix coverity issue CHECKED_RETURN Xiao Ni
2024-07-26 7:14 ` [PATCH 10/14] mdadm/super0: fix coverity issue CHECKED_RETURN and EVALUATION_ORDER Xiao Ni
2024-07-26 7:14 ` [PATCH 11/14] mdadm/super1: fix coverity issue CHECKED_RETURN Xiao Ni
2024-07-26 7:14 ` [PATCH 12/14] mdadm/super1: fix coverity issue DEADCODE Xiao Ni
2024-07-26 7:14 ` [PATCH 13/14] mdadm/super1: fix coverity issue EVALUATION_ORDER Xiao Ni
2024-07-26 7:14 ` [PATCH 14/14] mdadm/super1: fix coverity issue RESOURCE_LEAK Xiao Ni
2024-07-26 8:01 ` [PATCH V4 00/14] mdadm: fix coverity issues Paul Menzel
2024-07-30 13:51 ` Mariusz Tkaczyk [this message]
2024-08-05 9:20 ` Mariusz Tkaczyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240730155106.00001560@linux.intel.com \
--to=mariusz.tkaczyk@linux.intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=ncroxon@redhat.com \
--cc=pmenzel@molgen.mpg.de \
--cc=xni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.