From: Simon Horman <horms@kernel.org>
To: John Wang <wangzq.jn@gmail.com>
Cc: Jeremy Kerr <jk@codeconstruct.com.au>,
Matt Johnston <matt@codeconstruct.com.au>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: mctp: Consistent peer address handling in ioctl tag allocation
Date: Tue, 30 Jul 2024 20:05:59 +0100 [thread overview]
Message-ID: <20240730190559.GK1967603@kernel.org> (raw)
In-Reply-To: <20240730034031.87151-1-wangzhiqiang02@ieisystem.com>
On Tue, Jul 30, 2024 at 11:40:31AM +0800, John Wang wrote:
> When executing ioctl to allocate tags, if the peer address is 0,
> mctp_alloc_local_tag now replaces it with 0xff. However, during tag
> dropping, this replacement is not performed, potentially causing the key
> not to be dropped as expected.
>
> Signed-off-by: John Wang <wangzhiqiang02@ieisystem.com>
> Change-Id: I9c75aa8aff4bc048dd3be563f7f50a6fb14dc028
Hi John,
This is not a full review, so I would recommend waiting for feedback
from others, but please:
1. Do not include the Change-Id as it is not obvious what public
resource it references
2. As this is a fix targeted at net, please do include a Fixes tag,
indicating the commit where this user-visible problem first
manifested.
Also, as an aside, please wait 24h between posting updated patches.
Link: https://docs.kernel.org/process/maintainer-netdev.html
...
prev parent reply other threads:[~2024-07-30 19:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 3:40 [PATCH net] net: mctp: Consistent peer address handling in ioctl tag allocation John Wang
2024-07-30 19:05 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240730190559.GK1967603@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jk@codeconstruct.com.au \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeconstruct.com.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wangzq.jn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.