From: Greg KH <gregkh@linuxfoundation.org>
To: zhangjiao2 <zhangjiao2@cmss.chinamobile.com>
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org, trivial@kernel.org
Subject: Re: [PATCH v2] char: misc: add missing #ifdef CONFIG_PROC_FS
Date: Tue, 30 Jul 2024 11:11:10 +0200 [thread overview]
Message-ID: <2024073029-zippy-bats-ca30@gregkh> (raw)
In-Reply-To: <20240730083158.3583-1-zhangjiao2@cmss.chinamobile.com>
On Tue, Jul 30, 2024 at 04:31:58PM +0800, zhangjiao2 wrote:
> From: Zhang Jiao <zhangjiao2@cmss.chinamobile.com>
>
> Since misc_seq_ops is defined under CONFIG_PROC_FS in this file,
> it also need under CONFIG_PROC_FS when use.
>
> >Again, why is a #ifdef ok in this .c file? What changed to suddenly
> >require this?
> There is another #ifdef in this file, in there "misc_seq_ops" is defined.
> If CONFIG_PROC_FS is not defined, proc_create_seq is using an
> undefined variable "misc_seq_ops", this may cause compile error.
>
Why is this in the changelog text?
And what changed to suddenly require this proposed patch? What commit
id does it fix?
confused,
greg k-h
next prev parent reply other threads:[~2024-07-30 9:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 7:35 [PATCH] char: misc: add missing #ifdef CONFIG_PROC_FS and error checking zhangjiao2
2024-07-29 9:42 ` Arnd Bergmann
2024-07-30 8:03 ` [PATCH v2] char: misc: add missing #ifdef CONFIG_PROC_FS zhangjiao2
2024-07-30 8:42 ` Greg KH
2024-07-30 8:31 ` zhangjiao2
2024-07-30 9:11 ` Greg KH [this message]
2024-07-30 10:25 ` Arnd Bergmann
2024-07-29 9:43 ` [PATCH] char: misc: add missing #ifdef CONFIG_PROC_FS and error checking Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024073029-zippy-bats-ca30@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
--cc=zhangjiao2@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.