Re: [Buildroot] [PATCH v5] Config.in: ban textrels on musl toolchains

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "J. Neuschäfer" <j.neuschaefer@gmx.net>
Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>,
	"J. Neuschäfer via buildroot" <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH v5] Config.in: ban textrels on musl toolchains
Date: Wed, 31 Jul 2024 00:03:59 +0200	[thread overview]
Message-ID: <20240731000359.270740ba@windsurf> (raw)
In-Reply-To: <20240719-ztext-v5-1-ec46696d4ed9@gmx.net>

Hello J,

On Fri, 19 Jul 2024 17:27:19 +0200
J. Neuschäfer via buildroot <buildroot@buildroot.org> wrote:

> +# See also: https://www.openwall.com/lists/musl/2020/09/25/4
> +ifeq ($(BR2_TOOLCHAIN_USES_MUSL):$(BR2_STATIC_LIBS),y:)
> +TARGET_LDFLAGS += -Wl,-z,text
> +endif

Unfortunately, this change is breaking the build of gnu-efi:

  http://autobuild.buildroot.net/results/e3d/e3dec7e0323a3fcb07269b3f9e73becaafeedecd/build-end.log

It seems like gnu-efi uses $(TARGET_LDFLAGS) directly as arguments to
the linker, not as arguments to gcc-used-as-a-linker, and the linker
doesn't know about -Wl,-z,-text.

So, either we to "-z text" which I believe is understood by both gcc
and ld, or we somehow fix gnu-efi.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot