From: Oleg Nesterov <oleg@redhat.com>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: andrii@kernel.org, peterz@infradead.org, jolsa@kernel.org,
rostedt@goodmis.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/5] uprobes: kill uprobe_register_refctr()
Date: Wed, 31 Jul 2024 09:56:52 +0200 [thread overview]
Message-ID: <20240731075651.GB12813@redhat.com> (raw)
In-Reply-To: <20240731143748.55bb97c1d68aea1f1946729d@kernel.org>
On 07/31, Masami Hiramatsu wrote:
>
> OK, but it seems
>
> tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c
>
> is still using uprobe_register_refctr().
>
> That should be updated too.
OOPS, thanks a lot :/
I'll send v3 with the additional change below in reply to 4/5 in a minute.
Masami, Peter, please let me know if you want me to resend the whole series.
Oleg.
--- a/tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c
+++ b/tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c
@@ -458,8 +458,8 @@ static int testmod_register_uprobe(loff_t offset)
if (err)
goto out;
- err = uprobe_register_refctr(d_real_inode(uprobe.path.dentry),
- offset, 0, &uprobe.consumer);
+ err = uprobe_register(d_real_inode(uprobe.path.dentry),
+ offset, 0, &uprobe.consumer);
if (err)
path_put(&uprobe.path);
else
next prev parent reply other threads:[~2024-07-31 7:57 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 13:44 [PATCH v2 0/5] uprobes: misc cleanups/simplifications Oleg Nesterov
2024-07-29 13:45 ` [PATCH v2 1/5] uprobes: document the usage of mm->mmap_lock Oleg Nesterov
2024-07-29 13:45 ` [PATCH v2 2/5] uprobes: is_trap_at_addr: don't use get_user_pages_remote() Oleg Nesterov
2024-07-29 13:45 ` [PATCH v2 3/5] uprobes: simplify error handling for alloc_uprobe() Oleg Nesterov
2024-07-29 13:45 ` [PATCH v2 4/5] uprobes: kill uprobe_register_refctr() Oleg Nesterov
2024-07-31 5:37 ` Masami Hiramatsu
2024-07-31 7:56 ` Oleg Nesterov [this message]
2024-07-31 8:10 ` [PATCH v3 " Oleg Nesterov
2024-07-29 13:45 ` [PATCH v2 5/5] uprobes: make uprobe_register() return struct uprobe * Oleg Nesterov
2024-07-31 5:39 ` Masami Hiramatsu
2024-07-31 7:44 ` Oleg Nesterov
2024-07-31 16:18 ` Andrii Nakryiko
2024-07-31 16:56 ` Peter Zijlstra
2024-07-31 17:01 ` Andrii Nakryiko
2024-07-31 17:05 ` Peter Zijlstra
2024-07-31 17:12 ` Andrii Nakryiko
2024-07-31 17:24 ` Oleg Nesterov
2024-07-31 17:17 ` Oleg Nesterov
2024-08-01 13:10 ` Peter Zijlstra
2024-08-01 11:32 ` Jiri Olsa
2024-08-01 12:00 ` Oleg Nesterov
2024-08-01 12:15 ` Jiri Olsa
2024-08-01 12:26 ` Oleg Nesterov
2024-08-01 13:07 ` Jiri Olsa
2024-07-30 7:42 ` [PATCH v2 0/5] uprobes: misc cleanups/simplifications Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240731075651.GB12813@redhat.com \
--to=oleg@redhat.com \
--cc=andrii@kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.