From: Florian Westphal <fw@strlen.de>
To: <netfilter-devel@vger.kernel.org>
Cc: Florian Westphal <fw@strlen.de>
Subject: [PATCH nft v2 0/5] src: mnl: rework list hooks infra
Date: Wed, 31 Jul 2024 18:51:00 +0200 [thread overview]
Message-ID: <20240731165111.32166-1-fw@strlen.de> (raw)
Turns out that not only was 'nft list hooks' mostly undocumented,
there was also confusion on what it should do.
First, clean this code up and make it strictly a tool to dump
the NFPROTO_X registered functions.
Then, remove the 'hook' function argument, this was still passed
from back in the day when one could ask to only dump e.g.
ipv4 prerouting. This ability is of little value, so don't restore
this but instead just remove the leftover code.
Next, allow dumping of netdev:egress hooks.
Lastly, document this in more detail and make it clear that this
dumps the netfilter hooks registered for the protocol families,
and nothing else.
Once this gets applied I intend to make
'nft list hooks netdev'
dump device hooks for all interfaces, if any, instead of a
'no device provided' warning.
Florian Westphal (5):
src: mnl: clean up hook listing code
src: mnl: make family specification more strict when listing
src: drop obsolete hook argument form hook dump functions
src: add egress support for 'list hooks'
doc: add documentation about list hooks feature
Makefile.am | 1 +
doc/additional-commands.txt | 116 ++++++++++++++++++++++++++++
doc/nft.txt | 63 +--------------
include/mnl.h | 2 +-
src/mnl.c | 150 ++++++++++++++----------------------
src/rule.c | 6 +-
6 files changed, 179 insertions(+), 159 deletions(-)
create mode 100644 doc/additional-commands.txt
--
2.44.2
next reply other threads:[~2024-07-31 17:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 16:51 Florian Westphal [this message]
2024-07-31 16:51 ` [PATCH nft v2 1/5] src: mnl: clean up hook listing code Florian Westphal
2024-07-31 16:51 ` [PATCH nft v2 2/5] src: mnl: make family specification more strict when listing Florian Westphal
2024-07-31 16:51 ` [PATCH nft v2 3/5] src: drop obsolete hook argument form hook dump functions Florian Westphal
2024-07-31 16:51 ` [PATCH nft v2 4/5] src: add egress support for 'list hooks' Florian Westphal
2024-07-31 16:51 ` [PATCH nft v2 5/5] doc: add documentation about list hooks feature Florian Westphal
2024-08-07 16:54 ` [PATCH nft v2 0/5] src: mnl: rework list hooks infra Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240731165111.32166-1-fw@strlen.de \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.