From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 712A014B097; Wed, 31 Jul 2024 23:52:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722469975; cv=none; b=L7D+HSlhZ0vzsAVpFH4bhPIKllSBz06S9AHtFZaHiCVmkb+0RxwON+OIliZ+0xj6pbvkXeUwMS2JkrOYG8hLaQKdg/cffeWxrTAw6wdp4/9lStjcidBvPid45v6bw7tCDDm3M0ysZvLmrl+aRwPFh9hkhnTh7AnH+JYuDAIfasY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722469975; c=relaxed/simple; bh=lm3j1xdzYpcpoFEdtpSi/NhrcwFeBNmRdzqD+wEVuI0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YOxuinHhuDGpAadQt4Eua++ko+Q2PZp38kgbecjFH1WpxPtLuE/T1AV0/V3awHaWbifCXScP8dW5xXD+ZmI9TNnIUaDHPqyL2eo9mYcFvIQdMPL04oTLhIC5q7OM74YC8cqLInYJQ6SC2/Sx5l/ArKzbcAoE6YQwbRQ4TYGfn9g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=P7osGmom; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="P7osGmom" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75140C116B1; Wed, 31 Jul 2024 23:52:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722469975; bh=lm3j1xdzYpcpoFEdtpSi/NhrcwFeBNmRdzqD+wEVuI0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=P7osGmom/a484+ejw0mw+VTijyJ1qBvZOE00p4wOUNcTO7/Ap3tXxnLoAajxa0f8m 5lX3xcM0AFw3wqi/nmZ4eJgrRFXt5O0JB4cRaGiST76rIl/TNDghvLSbmJmhoaAG6b G+mH1CAfvPRuwdEBNBYYVkPk97Wu9UkZxDY2EFQUlrqOjChx9ONsHdB7NNsoUXNrve yiR9hxyHIC7UJtN/2lQkc/EsS+8neoHY5F65JchlBVNivWHIQGh5HyZq9ufc2It4M4 f476cPG0hdIUcQW+0uVHLZD8BBngkwES7Y7Fb8INXdTSaJqkdEyT3FRIK3zIqAITXp d4948A/JOyvHw== Date: Wed, 31 Jul 2024 16:52:53 -0700 From: Jakub Kicinski To: Jacob Keller Cc: "Song, Yoong Siang" , "Neftin, Sasha" , Brett Creeley , "linux-doc@vger.kernel.org" , Alexei Starovoitov , "Eric Dumazet" , "Nguyen, Anthony L" , "Blanco Alcaine, Hector" , Daniel Borkmann , Jonathan Corbet , "Gomes, Vinicius" , "Kitszel, Przemyslaw" , John Fastabend , Shinas Rasheed , "intel-wired-lan@lists.osuosl.org" , Paolo Abeni , "Tian, Kevin" , Jesper Dangaard Brouer , Richard Cochran , "netdev@vger.kernel.org" , "Hay, Joshua A" , "linux-kernel@vger.kernel.org" , "bpf@vger.kernel.org" , "David S . Miller" Subject: Re: [Intel-wired-lan] [PATCH iwl-next, v1 0/3] Add Default Rx Queue Setting for igc driver Message-ID: <20240731165253.2571b254@kernel.org> In-Reply-To: References: <20240730012212.775814-1-yoong.siang.song@intel.com> <20240730075507.7cf8741f@kernel.org> <20240731074351.13676228@kernel.org> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 31 Jul 2024 09:41:16 -0700 Jacob Keller wrote: > In this case, (I haven't dug into the actual patches or code), I suspect > the driver will need to validate the location values when adding rules > to ensure that all rules which don't use the default queue have higher > priority than the wild card rule. The request to add a filter should > reject the rule in the case where a default queue rule was added with a > higher priority location. Maybe I shouldn't say it aloud but picking a "known" location for such a wildcard rule wouldn't be the worst thing. Obviously better if the driver just understand ordering! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A46BC3DA7F for ; Wed, 31 Jul 2024 23:52:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id F1A5D40E66; Wed, 31 Jul 2024 23:52:58 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id xdtwrutlpNma; Wed, 31 Jul 2024 23:52:58 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 2220040124 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1722469978; bh=lm3j1xdzYpcpoFEdtpSi/NhrcwFeBNmRdzqD+wEVuI0=; h=Date:From:To:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=I5gQlYoNLUeGkGWelK/TUx9F+zd5XviBOF/c1MHEBtht4wEmpbgS9aXX8QDognkj6 7EqOmzWgyomBcIyDiMQB5/rxpiIftg9BY/9WnjBqRM2ZE/+BLOSmiV77sH7NTXsUZT Orhv4ed1OefYC2pT+drV7QA6TzeTTqEsPfT0fgm+SdcqUyENZ0J/jwfjQVy06oXCAj lSBJkxbpWV6p+wtFvDJ9aFrG9nBP55kW3ApvnQvSeartkntK0QvyztD3z4NnCVp82L pG5DgubA9kAR06XVijuBJ3aBkb5ljmMHq0HedT1w4i+GNR80q+RcabkeNIJc5jkRFm ympVhRU7Z1+kw== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 2220040124; Wed, 31 Jul 2024 23:52:58 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 38DB91BF592 for ; Wed, 31 Jul 2024 23:52:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 3202481A50 for ; Wed, 31 Jul 2024 23:52:57 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id nWypEtQq7Aai for ; Wed, 31 Jul 2024 23:52:56 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 6A43781A4E DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 6A43781A4E Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by smtp1.osuosl.org (Postfix) with ESMTPS id 6A43781A4E for ; Wed, 31 Jul 2024 23:52:56 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9866E6260F; Wed, 31 Jul 2024 23:52:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75140C116B1; Wed, 31 Jul 2024 23:52:54 +0000 (UTC) Date: Wed, 31 Jul 2024 16:52:53 -0700 From: Jakub Kicinski To: Jacob Keller Message-ID: <20240731165253.2571b254@kernel.org> In-Reply-To: References: <20240730012212.775814-1-yoong.siang.song@intel.com> <20240730075507.7cf8741f@kernel.org> <20240731074351.13676228@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722469975; bh=lm3j1xdzYpcpoFEdtpSi/NhrcwFeBNmRdzqD+wEVuI0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=P7osGmom/a484+ejw0mw+VTijyJ1qBvZOE00p4wOUNcTO7/Ap3tXxnLoAajxa0f8m 5lX3xcM0AFw3wqi/nmZ4eJgrRFXt5O0JB4cRaGiST76rIl/TNDghvLSbmJmhoaAG6b G+mH1CAfvPRuwdEBNBYYVkPk97Wu9UkZxDY2EFQUlrqOjChx9ONsHdB7NNsoUXNrve yiR9hxyHIC7UJtN/2lQkc/EsS+8neoHY5F65JchlBVNivWHIQGh5HyZq9ufc2It4M4 f476cPG0hdIUcQW+0uVHLZD8BBngkwES7Y7Fb8INXdTSaJqkdEyT3FRIK3zIqAITXp d4948A/JOyvHw== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=none dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=P7osGmom Subject: Re: [Intel-wired-lan] [PATCH iwl-next, v1 0/3] Add Default Rx Queue Setting for igc driver X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Neftin, Sasha" , Brett Creeley , "linux-doc@vger.kernel.org" , Alexei Starovoitov , Eric Dumazet , "Nguyen, Anthony L" , "Blanco Alcaine, Hector" , Daniel Borkmann , Jonathan Corbet , "Gomes, Vinicius" , "Kitszel, Przemyslaw" , John Fastabend , Shinas Rasheed , "intel-wired-lan@lists.osuosl.org" , Paolo Abeni , "Tian, Kevin" , Jesper Dangaard Brouer , Richard Cochran , "netdev@vger.kernel.org" , "Hay, Joshua A" , "linux-kernel@vger.kernel.org" , "Song, Yoong Siang" , "bpf@vger.kernel.org" , "David S . Miller" Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Wed, 31 Jul 2024 09:41:16 -0700 Jacob Keller wrote: > In this case, (I haven't dug into the actual patches or code), I suspect > the driver will need to validate the location values when adding rules > to ensure that all rules which don't use the default queue have higher > priority than the wild card rule. The request to add a filter should > reject the rule in the case where a default queue rule was added with a > higher priority location. Maybe I shouldn't say it aloud but picking a "known" location for such a wildcard rule wouldn't be the worst thing. Obviously better if the driver just understand ordering!