From: Jakub Kicinski <kuba@kernel.org>
To: Simon Horman <horms@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] ethtool: Don't check for NULL info in prepare_data callbacks
Date: Wed, 31 Jul 2024 18:20:43 -0700 [thread overview]
Message-ID: <20240731182043.51286ac6@kernel.org> (raw)
In-Reply-To: <20240731-prepare_data-null-check-v1-1-627f2320678f@kernel.org>
On Wed, 31 Jul 2024 10:15:28 +0100 Simon Horman wrote:
> Since commit f946270d05c2 ("ethtool: netlink: always pass genl_info to
> .prepare_data") the info argument of prepare_data callbacks is never
> NULL. Remove checks present in callback implementations.
>
> Link: https://lore.kernel.org/netdev/20240703121237.3f8b9125@kernel.org/
> Signed-off-by: Simon Horman <horms@kernel.org>
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
next prev parent reply other threads:[~2024-08-01 1:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 9:15 [PATCH net-next] ethtool: Don't check for NULL info in prepare_data callbacks Simon Horman
2024-08-01 1:20 ` Jakub Kicinski [this message]
2024-08-01 16:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240731182043.51286ac6@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.