From: "Michael S. Tsirkin" <mst@redhat.com>
To: Akihiko Odaki <akihiko.odaki@daynix.com>
Cc: "Markus Armbruster" <armbru@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Cédric Le Goater" <clg@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Sriram Yagnaraman" <sriram.yagnaraman@ericsson.com>,
"Jason Wang" <jasowang@redhat.com>,
"Keith Busch" <kbusch@kernel.org>,
"Klaus Jensen" <its@irrelevant.dk>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PATCH v2 0/4] hw/pci: Convert rom_bar into OnOffAuto
Date: Thu, 1 Aug 2024 03:52:45 -0400 [thread overview]
Message-ID: <20240801035118-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <8ee4464e-f9b3-48bc-9fa3-0b5f0d2a5faf@daynix.com>
On Thu, Aug 01, 2024 at 04:01:44PM +0900, Akihiko Odaki wrote:
> rom_bar_set() and and underlying visit_type_str_preserving() are ugly, but
> we can remove them once the deprecation period ends. On the other hand, if
> we don't make this change, dev->opts will keep floating around, and we will
> even have another use of it for "[PATCH v5 1/8] hw/pci: Do not add ROM BAR
> for SR-IOV VF"[1]. Eventually, having this refactoring early will result in
> less mess in the future.
>
> [1]: lore.kernel.org/r/20240715-sriov-v5-1-3f5539093ffc@daynix.com
I don't know that this should worry us much. Is there some project that
requires getting rid of dev->opts for some reason?
--
MST
next prev parent reply other threads:[~2024-08-01 7:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-14 7:48 [PATCH v2 0/4] hw/pci: Convert rom_bar into OnOffAuto Akihiko Odaki
2024-07-14 7:48 ` [PATCH v2 1/4] qapi: Add visit_type_str_preserving() Akihiko Odaki
2024-07-14 7:48 ` [PATCH v2 2/4] qapi: Do not consume a value when visit_type_enum() fails Akihiko Odaki
2024-07-14 7:48 ` [PATCH v2 3/4] hw/pci: Convert rom_bar into OnOffAuto Akihiko Odaki
2024-07-14 7:48 ` [PATCH v2 4/4] hw/qdev: Remove opts member Akihiko Odaki
2024-07-31 8:32 ` [PATCH v2 0/4] hw/pci: Convert rom_bar into OnOffAuto Markus Armbruster
2024-07-31 8:40 ` Michael S. Tsirkin
2024-08-01 7:01 ` Akihiko Odaki
2024-08-01 7:52 ` Michael S. Tsirkin [this message]
2024-08-01 8:39 ` Akihiko Odaki
2024-08-01 11:05 ` Markus Armbruster
2024-08-01 10:59 ` Markus Armbruster
2024-08-01 12:22 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240801035118-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=akihiko.odaki@daynix.com \
--cc=alex.williamson@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=clg@redhat.com \
--cc=eduardo@habkost.net \
--cc=its@irrelevant.dk \
--cc=jasowang@redhat.com \
--cc=kbusch@kernel.org \
--cc=marcel.apfelbaum@gmail.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sriram.yagnaraman@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.