From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3EE3647 for ; Thu, 1 Aug 2024 07:00:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722495644; cv=none; b=LC2TVblWJ6bLwfKS0K7wKE64O6hnqlva2AxvDpBmbQpUb30Lj41R049u837ytoZcpcObNqKN9PQQrDjfnvv+f4W6jaopr+qVeB6bqXcMJvVZrt+IKGjXqJlwh6W8sqpKy8vCh4tZwc/3aGaMsnkTuISyBsByHJ9JGd7u7SC9np8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722495644; c=relaxed/simple; bh=KSLg0yzqiI4hPE5ov3n8SQ0mekRG7ftBEc5L0sChKyo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mMmeJfxmOarNIuQnpdQ/2y8ynhbLI73VK8T1txmTlAg2dQxJzkhjMoQM2WcZsEWl1UFzlnX6dtsnOVBnX4jLibYWzS+0BO7YGKp1B7V1Ru3GnDzn0mxrlX2lKTE9GQxgvzRk36ROCx002bsdURDi56hFY8cbmrlWVSiOxoGKbZ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=AHL1CJmp; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AHL1CJmp" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-70d2b921cd1so5834536b3a.1 for ; Thu, 01 Aug 2024 00:00:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1722495642; x=1723100442; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Mnbrn+r8w67xaS4dRlv2WYPfTmOAIm6sgMTn3y+iDAw=; b=AHL1CJmp2PcBF3O+ghTSTaylWJyxJ2QkXwhEf3ak5yDUS1nUf5gDQA3av0u9nhQvAd hlIG+DjpFmGPjT8wOsoDDNnFbWFcji2zuIUfFUueBOx2Cp3kj8PbsRhh11BoHmawQaTL e9t2TGtlDbi02PXckC8U8FFyn94/GgUxk0lZO/g7RXtdkdXpZLvEZWkyM7sXXsc5i0DE 8R4tw0s1GRsHSlJ/hGBHPL4kASL3W5Rskixgagd7YZqFVbRrmvwqDmKoYwgiWpQq4vnI bT8NdP75Ud5E0ZUGADGjXcH6EaExYECfCbxZzGZZdj/Jw4ADeSi9LEchRu5MdIQgSazS ccWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722495642; x=1723100442; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Mnbrn+r8w67xaS4dRlv2WYPfTmOAIm6sgMTn3y+iDAw=; b=vLQrevWtjvLSuH7gqQW0yf18ZoyCEXqx48DqfL7qYaG+Thkxch7FI0IelHaZCviflj 8ohcUXRUDZ+xD+Rq873LMX4u6O9Gt69drfZCzZ4T6CXVqH/nHsDjcfhwJKSDQ98qxOWV Wf/vipg+9dx5UD7Q79rci5YZt6yayLCcihEPyaGTU7uD3nixPnpatM5U/vChOcvWeB5s Y4451T5lZ5xNnk3o2THFe3bdiVW4vYSRe3oCsG1t3VgVGQjoYB4/RXno3tyDzpIh7dgg PEoINOZxWztnVNzU8XEq9lyT745acVK3bSmtLJY8a6QCxvrs8h6RoILosa6r+Jnfg/PO Yebg== X-Forwarded-Encrypted: i=1; AJvYcCU9DVuta8p0hPP83BJGfAIw994WIqGE8YwqN7KDrEZatNj8ZLqIih0o8hE+lPGwJd+qCPDONHMHhJr7otdO9yGmdm3fAVfi9dPL0LI3Bw== X-Gm-Message-State: AOJu0Yy6imCsyqun479YA+178hD8g9z6VFqBLdXY1wp1QSjHDQoFHOGO N4KUw0KBUcp80kQpIbGd/HQLTsgsDfZ6gB3ryN+AGTRcRIQd6/Q8p7LvrguGtQ== X-Google-Smtp-Source: AGHT+IEaoqcF6Og6OLvQ7ewWaGYFAcW4sjoa1hHGd0TMPSQdLKOqtrUdh28Iv6TE2SdAUU8BvpA24Q== X-Received: by 2002:a05:6a20:9f0f:b0:1c4:aedd:7b97 with SMTP id adf61e73a8af0-1c68cf632a9mr2147243637.32.1722495642281; Thu, 01 Aug 2024 00:00:42 -0700 (PDT) Received: from thinkpad ([120.60.66.23]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70ead8834b1sm11302281b3a.178.2024.08.01.00.00.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Aug 2024 00:00:41 -0700 (PDT) Date: Thu, 1 Aug 2024 12:30:26 +0530 From: Manivannan Sadhasivam To: Vinod Koul Cc: kishon@kernel.org, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, dmitry.baryshkov@linaro.org Subject: Re: [PATCH v3] phy: qcom: qmp: Add debug prints for register writes Message-ID: <20240801070026.GB3705@thinkpad> References: <20240731152548.102987-1-manivannan.sadhasivam@linaro.org> <172249532035.256913.2685367794999812971.b4-ty@kernel.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <172249532035.256913.2685367794999812971.b4-ty@kernel.org> On Thu, Aug 01, 2024 at 12:25:20PM +0530, Vinod Koul wrote: > > On Wed, 31 Jul 2024 20:55:48 +0530, Manivannan Sadhasivam wrote: > > These register prints are useful to validate the init sequence against the > > Qcom internal documentation and also to share with the Qcom hw engineers to > > debug issues related to PHY. > > > > Sample debug prints: > > > > qcom-qmp-pcie-phy 1c0e000.phy: Writing Reg: QSERDES_V5_COM_SYSCLK_EN_SEL Offset: 0x0094 Val: 0xd9 > > qcom-qmp-pcie-phy 1c0e000.phy: Writing Reg: QSERDES_V5_COM_HSCLK_SEL Offset: 0x0158 Val: 0x11 > > > > [...] > > Applied, thanks! > > [1/1] phy: qcom: qmp: Add debug prints for register writes > commit: 4e92d504475ea5841716ad775f412342520a3d26 > Thanks! Bjorn spotted that it is worth making 'char *name' a const. Can you please ammend the commit? - Mani -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41174C3DA64 for ; Thu, 1 Aug 2024 07:00:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=seh5Xp68FBlkBMq5KqQfmeMsBHUD9ezEHrbPhL+zmT4=; b=yyAITkHpsitNNk BfkQgtp4G1MhalzJQC2SnCK+VB4L/+SDseLGUxpipsdc/Db23mw0nNTNLySXy4be/ko/cRYIuWwVo ITqfWs9hJMlsgkbANOLdFlCIqpeZM8+C212qfUqDolcU62c+ELgcTa1i88++VkdnTsput3xktqOY8 ysoJFBR0GjjU7tZFCOrQmTOBvmvxWMHikmJu/f3KmJYWmUkjq9lUwPIYBvQIu9P/JgD5679eGf2l6 5zXr8QDPvLpyL2YVEta4zlBeKamuB1ZSG8BTV45hIUV6k/TLFjRwfVuYwsXJ9Ak4gG/0TzRA1WlDv qqBpRjVyvx23tJHDOvwg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZPnp-000000046Kf-3r4Z; Thu, 01 Aug 2024 07:00:45 +0000 Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZPnn-000000046KA-2clL for linux-phy@lists.infradead.org; Thu, 01 Aug 2024 07:00:44 +0000 Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-70d2b921cd1so5834537b3a.1 for ; Thu, 01 Aug 2024 00:00:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1722495642; x=1723100442; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Mnbrn+r8w67xaS4dRlv2WYPfTmOAIm6sgMTn3y+iDAw=; b=bjVqIdZWvtJlITN4+LGfLdDJv9V9E4iBL1u2ffPyHloUhWY1NbGLew7MLRYezRS/WI ySbScJEyjIMkjw362UKq2mXyta8UKSHVYKysyhXWISlE4fTF8Sb12dP+mGGEVFrKYEmG vrrxGF5JteRtQMQifrWnYdJNRA3I0/1oO1IBW7S3xJjS6ofnojaPwzFDoAok0mgZv9je fk2A5GMoYZSHfi8P6UPBSMf0bxOYXTMEHYxF3kzrhQYMKsfcGZVdasrxqncPVCpmyfN1 IZTYaeVAa3PmvcHA23wv3Rue/YrbadXYCfnG09FCrrlfyWhDHaAmUGygu8j/nMxxYshq ws0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722495642; x=1723100442; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Mnbrn+r8w67xaS4dRlv2WYPfTmOAIm6sgMTn3y+iDAw=; b=sxdLR6zwlhvF4hgD3ybZooyUvWEyoaofWli0LADw4R9nz6tz5UtGlmVhVyQfe4rztl 5I2SNxLDU+nnRSzpdPt4wWPqEQD0KtqsRtT0ltpJo+lcaraD0/DcBZBzgLcWmsdB0iOX jyESF1vf+07VTKkz7xKzYinodFT5hjVIal2zwu3fbUmMzldNuUbtzS8Z9J4gC8nFoJbG jV3iTJCLgJDP4CnACtVEtF6NUhElDsL+8L0yGBMyDRFvtyk33/EuvayqgkoiJF8D4Wb6 l8ERMTaFNxbDFU7at63CX+cPWwUys6haCebvzRNcHi2qNEqyslrPRaeL/i8wejTPwoD3 i5wQ== X-Forwarded-Encrypted: i=1; AJvYcCXD13A52usMW1PgzzypBriPEPq9LE3B7QElpEtW3K+B04EWGyW48h32VKoBVDqdQX6R2BY++17MamG00QdiIL+oOebQriSRUJ6lj+3QUQ== X-Gm-Message-State: AOJu0YyOvp6hkmrYQ69BT3jucxulGJXPFjWwjlEBMidbIb/mHmopV/oz g0fUdUqHmP8rWVSZQDtowV9mWMICV3VgFXLJ91aBDWfNpDnerizJx1rn9FFBlQ== X-Google-Smtp-Source: AGHT+IEaoqcF6Og6OLvQ7ewWaGYFAcW4sjoa1hHGd0TMPSQdLKOqtrUdh28Iv6TE2SdAUU8BvpA24Q== X-Received: by 2002:a05:6a20:9f0f:b0:1c4:aedd:7b97 with SMTP id adf61e73a8af0-1c68cf632a9mr2147243637.32.1722495642281; Thu, 01 Aug 2024 00:00:42 -0700 (PDT) Received: from thinkpad ([120.60.66.23]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70ead8834b1sm11302281b3a.178.2024.08.01.00.00.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Aug 2024 00:00:41 -0700 (PDT) Date: Thu, 1 Aug 2024 12:30:26 +0530 From: Manivannan Sadhasivam To: Vinod Koul Cc: kishon@kernel.org, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, dmitry.baryshkov@linaro.org Subject: Re: [PATCH v3] phy: qcom: qmp: Add debug prints for register writes Message-ID: <20240801070026.GB3705@thinkpad> References: <20240731152548.102987-1-manivannan.sadhasivam@linaro.org> <172249532035.256913.2685367794999812971.b4-ty@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <172249532035.256913.2685367794999812971.b4-ty@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240801_000043_686929_3EF07682 X-CRM114-Status: UNSURE ( 9.66 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org T24gVGh1LCBBdWcgMDEsIDIwMjQgYXQgMTI6MjU6MjBQTSArMDUzMCwgVmlub2QgS291bCB3cm90 ZToKPiAKPiBPbiBXZWQsIDMxIEp1bCAyMDI0IDIwOjU1OjQ4ICswNTMwLCBNYW5pdmFubmFuIFNh ZGhhc2l2YW0gd3JvdGU6Cj4gPiBUaGVzZSByZWdpc3RlciBwcmludHMgYXJlIHVzZWZ1bCB0byB2 YWxpZGF0ZSB0aGUgaW5pdCBzZXF1ZW5jZSBhZ2FpbnN0IHRoZQo+ID4gUWNvbSBpbnRlcm5hbCBk b2N1bWVudGF0aW9uIGFuZCBhbHNvIHRvIHNoYXJlIHdpdGggdGhlIFFjb20gaHcgZW5naW5lZXJz IHRvCj4gPiBkZWJ1ZyBpc3N1ZXMgcmVsYXRlZCB0byBQSFkuCj4gPiAKPiA+IFNhbXBsZSBkZWJ1 ZyBwcmludHM6Cj4gPiAKPiA+IHFjb20tcW1wLXBjaWUtcGh5IDFjMGUwMDAucGh5OiBXcml0aW5n IFJlZzogUVNFUkRFU19WNV9DT01fU1lTQ0xLX0VOX1NFTCBPZmZzZXQ6IDB4MDA5NCBWYWw6IDB4 ZDkKPiA+IHFjb20tcW1wLXBjaWUtcGh5IDFjMGUwMDAucGh5OiBXcml0aW5nIFJlZzogUVNFUkRF U19WNV9DT01fSFNDTEtfU0VMIE9mZnNldDogMHgwMTU4IFZhbDogMHgxMQo+ID4gCj4gPiBbLi4u XQo+IAo+IEFwcGxpZWQsIHRoYW5rcyEKPiAKPiBbMS8xXSBwaHk6IHFjb206IHFtcDogQWRkIGRl YnVnIHByaW50cyBmb3IgcmVnaXN0ZXIgd3JpdGVzCj4gICAgICAgY29tbWl0OiA0ZTkyZDUwNDQ3 NWVhNTg0MTcxNmFkNzc1ZjQxMjM0MjUyMGEzZDI2Cj4gCgpUaGFua3MhIEJqb3JuIHNwb3R0ZWQg dGhhdCBpdCBpcyB3b3J0aCBtYWtpbmcgJ2NoYXIgKm5hbWUnIGEgY29uc3QuIENhbiB5b3UKcGxl YXNlIGFtbWVuZCB0aGUgY29tbWl0PwoKLSBNYW5pCgotLSAK4K6u4K6j4K6/4K614K6j4K+N4K6j 4K6p4K+NIOCumuCupOCuvuCumuCuv+CuteCuruCvjQoKLS0gCmxpbnV4LXBoeSBtYWlsaW5nIGxp c3QKbGludXgtcGh5QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cHM6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcGh5Cg==