From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: "Akihiko Odaki" <akihiko.odaki@daynix.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Yuri Benditovich" <yuri.benditovich@daynix.com>,
eduardo@habkost.net, marcel.apfelbaum@gmail.com,
philmd@linaro.org, wangyanan55@huawei.com,
dmitry.fleytman@gmail.com, jasowang@redhat.com,
sriram.yagnaraman@est.tech, sw@weilnetz.de,
qemu-devel@nongnu.org, yan@daynix.com,
"Fabiano Rosas" <farosas@suse.de>,
devel@lists.libvirt.org
Subject: Re: [PATCH v2 4/4] virtio-net: Add support for USO features
Date: Thu, 1 Aug 2024 11:15:47 -0400 [thread overview]
Message-ID: <20240801111435-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <ZqumIZcs1tCNTpRE@x1n>
On Thu, Aug 01, 2024 at 11:13:37AM -0400, Peter Xu wrote:
> Do we really concern about users not enabling features that much? I
> thought users always can manually change the XML and add whatever they
> need, and device properties do not like too special here to me. I mean, we
> have bunch of "features" exported as new "-devices" and users must opt-in
> for them by changing the XML. We never worried on user not using them. I
> doubt whether we worried too much on user not opt-in, especially for
> performance features, because they're, IMHO, targeting advanced users.
What I do not like, is pushing the knowledge of what good defaults
are to libvirt.
--
MST
next prev parent reply other threads:[~2024-08-01 15:17 UTC|newest]
Thread overview: 107+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 22:31 [PATCH v2 0/4] virtio-net: add USO feature (UDP segmentation offload) Yuri Benditovich
2023-07-31 22:31 ` [PATCH v2 1/4] tap: Add USO support to tap device Yuri Benditovich
2023-07-31 22:31 ` [PATCH v2 2/4] tap: Add check for USO features Yuri Benditovich
2023-07-31 22:31 ` [PATCH v2 3/4] virtio-net: Add USO flags to vhost support Yuri Benditovich
2023-07-31 22:31 ` [PATCH v2 4/4] virtio-net: Add support for USO features Yuri Benditovich
2023-08-02 5:17 ` Akihiko Odaki
2024-07-25 22:18 ` Peter Xu
2024-07-26 2:12 ` Jason Wang
2024-07-26 15:01 ` Peter Xu
2024-07-26 6:08 ` Michael S. Tsirkin
2024-07-26 7:03 ` Thomas Huth
2024-07-26 7:25 ` Michael S. Tsirkin
2024-07-26 11:32 ` Peter Xu
2024-07-26 17:39 ` Thomas Huth
2024-07-26 20:55 ` Peter Xu
2024-08-01 5:41 ` Michael S. Tsirkin
2024-07-26 8:48 ` Daniel P. Berrangé
2024-07-26 14:43 ` Peter Xu
2024-07-26 15:17 ` Daniel P. Berrangé
2024-07-26 20:47 ` Peter Xu
2024-07-28 15:18 ` Akihiko Odaki
2024-07-29 3:50 ` Jason Wang
2024-07-29 4:45 ` Akihiko Odaki
2024-07-29 14:29 ` Peter Xu
2024-07-29 16:43 ` Akihiko Odaki
2024-07-30 2:04 ` Jason Wang
2024-07-30 2:57 ` Akihiko Odaki
2024-07-30 3:03 ` Jason Wang
2024-07-30 3:11 ` Akihiko Odaki
2024-07-30 3:17 ` Jason Wang
2024-07-30 3:28 ` Akihiko Odaki
2024-07-30 3:45 ` Jason Wang
2024-07-30 10:23 ` Akihiko Odaki
2024-07-30 11:52 ` Yuri Benditovich
2024-07-31 2:05 ` Jason Wang
2024-07-29 15:58 ` Daniel P. Berrangé
2024-07-29 17:00 ` Peter Xu
2024-07-29 17:23 ` Akihiko Odaki
2024-07-30 18:02 ` Peter Xu
2024-07-29 17:26 ` Daniel P. Berrangé
2024-07-30 18:13 ` Peter Xu
2024-07-30 18:46 ` Daniel P. Berrangé
2024-07-30 19:11 ` Peter Xu
2024-07-30 19:22 ` Michael S. Tsirkin
2024-07-30 20:03 ` Peter Xu
2024-07-30 21:32 ` Michael S. Tsirkin
2024-07-30 22:01 ` Peter Xu
2024-07-31 2:01 ` Jason Wang
2024-07-31 7:04 ` Daniel P. Berrangé
2024-07-31 7:41 ` Michael S. Tsirkin
2024-07-31 12:57 ` Peter Xu
2024-08-01 2:28 ` Jason Wang
2024-08-01 5:28 ` Akihiko Odaki
2024-08-01 5:34 ` Michael S. Tsirkin
2024-08-01 5:51 ` Michael S. Tsirkin
2024-08-01 15:36 ` Peter Xu
2024-08-01 15:39 ` Michael S. Tsirkin
2024-08-01 15:45 ` Daniel P. Berrangé
2024-08-01 15:50 ` Michael S. Tsirkin
2024-08-01 15:58 ` Daniel P. Berrangé
2024-08-01 5:05 ` Akihiko Odaki
2024-08-01 15:13 ` Peter Xu
2024-08-01 15:15 ` Michael S. Tsirkin [this message]
2024-08-01 15:25 ` Daniel P. Berrangé
2024-08-02 4:30 ` Akihiko Odaki
2024-08-02 13:21 ` Michael S. Tsirkin
2024-08-02 15:05 ` Peter Xu
2024-08-02 15:54 ` Akihiko Odaki
2024-08-02 16:26 ` Peter Xu
2024-08-02 16:40 ` Michael S. Tsirkin
2024-08-02 20:56 ` Peter Xu
2024-08-04 6:49 ` Akihiko Odaki
2024-08-04 13:08 ` Peter Xu
2024-08-04 13:41 ` Michael S. Tsirkin
2024-08-05 7:27 ` Akihiko Odaki
2024-08-06 20:41 ` Peter Xu
2024-08-08 11:43 ` Akihiko Odaki
2024-08-08 13:55 ` Peter Xu
2024-08-08 14:45 ` Michael S. Tsirkin
2024-08-09 10:28 ` Akihiko Odaki
2024-08-05 7:30 ` Michael S. Tsirkin
2024-08-05 7:53 ` Akihiko Odaki
2024-08-05 8:23 ` Michael S. Tsirkin
2024-08-05 9:37 ` Akihiko Odaki
2024-08-05 10:08 ` Michael S. Tsirkin
2024-08-06 7:35 ` Akihiko Odaki
2024-08-06 13:29 ` Michael S. Tsirkin
2024-08-08 10:52 ` Akihiko Odaki
2024-08-08 10:54 ` Michael S. Tsirkin
2024-08-08 11:03 ` Akihiko Odaki
2024-08-08 11:12 ` Michael S. Tsirkin
2024-08-08 11:32 ` Akihiko Odaki
2024-08-08 14:21 ` Peter Xu
2024-08-08 14:15 ` Peter Xu
2024-08-08 14:47 ` Michael S. Tsirkin
2024-08-08 15:25 ` Peter Xu
2024-08-09 12:50 ` Fabiano Rosas
2024-08-18 5:04 ` Akihiko Odaki
2024-08-18 7:03 ` Michael S. Tsirkin
2024-08-19 4:27 ` Akihiko Odaki
2024-08-11 7:35 ` Michael S. Tsirkin
2024-08-18 5:09 ` Akihiko Odaki
2024-07-29 17:02 ` Akihiko Odaki
2024-08-01 5:38 ` Michael S. Tsirkin
2024-07-29 3:52 ` Jason Wang
2023-08-09 20:21 ` [PATCH v2 0/4] virtio-net: add USO feature (UDP segmentation offload) Yuri Benditovich
2023-08-10 3:14 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240801111435-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=akihiko.odaki@daynix.com \
--cc=berrange@redhat.com \
--cc=devel@lists.libvirt.org \
--cc=dmitry.fleytman@gmail.com \
--cc=eduardo@habkost.net \
--cc=farosas@suse.de \
--cc=jasowang@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sriram.yagnaraman@est.tech \
--cc=sw@weilnetz.de \
--cc=thuth@redhat.com \
--cc=wangyanan55@huawei.com \
--cc=yan@daynix.com \
--cc=yuri.benditovich@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.