From: Jakub Kicinski <kuba@kernel.org>
To: Jeongjun Park <aha310510@gmail.com>
Cc: jiri@resnulli.us, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
syzbot+b668da2bc4cb9670bf58@syzkaller.appspotmail.com
Subject: Re: [PATCH net] team: fix possible deadlock in team_port_change_check
Date: Thu, 1 Aug 2024 17:49:58 -0700 [thread overview]
Message-ID: <20240801174958.050db514@kernel.org> (raw)
In-Reply-To: <CAO9qdTHJKMzOTRJB_N1VPjh2=Z=qLkpzu8eL5mcAr6hnFfiHXQ@mail.gmail.com>
On Fri, 2 Aug 2024 07:51:19 +0900 Jeongjun Park wrote:
> > You didn't even run this thru checkpatch, let alone the fact that its
> > reimplementing nested locks (or trying to) :(
> >
> > Some of the syzbot reports are not fixed because they are either hard
> > or because there is a long standing disagreement on how to solve them.
> > Please keep that in mind.
>
> Okay, but I have a question. Is it true that team devices can also be
> protected through rtnl? As far as I know, rtnl only protects net_device,
> so I didn't think about removing the lock for team->lock.
Yes, but I think that gets us into the "long standing disagreement"
territory :) You may be able to find previous attempt to remove
team->lock in the mailing list archive.
prev parent reply other threads:[~2024-08-02 0:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 11:18 [PATCH net] team: fix possible deadlock in team_port_change_check Jeongjun Park
2024-08-01 14:28 ` Jakub Kicinski
2024-08-01 22:51 ` Jeongjun Park
2024-08-02 0:49 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240801174958.050db514@kernel.org \
--to=kuba@kernel.org \
--cc=aha310510@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+b668da2bc4cb9670bf58@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.