From: Simon Horman <horms@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com
Subject: Re: [PATCH net-next] net: remove IFF_* re-definition
Date: Thu, 1 Aug 2024 20:36:50 +0100 [thread overview]
Message-ID: <20240801193650.GB2495006@kernel.org> (raw)
In-Reply-To: <20240801163401.378723-1-kuba@kernel.org>
On Thu, Aug 01, 2024 at 09:34:01AM -0700, Jakub Kicinski wrote:
> We re-define values of enum netdev_priv_flags as preprocessor
> macros with the same name. I guess this was done to avoid breaking
> out of tree modules which may use #ifdef X for kernel compatibility?
> Commit 7aa98047df95 ("net: move net_device priv_flags out from UAPI")
> which added the enum doesn't say. In any case, the flags with defines
> are quite old now, and defines for new flags don't get added.
> OOT drivers have to resort to code greps for compat detection, anyway.
> Let's delete these defines, save LoC, help LXR link to the right place.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-08-01 19:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 16:34 [PATCH net-next] net: remove IFF_* re-definition Jakub Kicinski
2024-08-01 19:36 ` Simon Horman [this message]
2024-08-02 6:58 ` Jiri Pirko
2024-08-02 23:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240801193650.GB2495006@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.