All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Baruch Siach via buildroot <buildroot@buildroot.org>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
Subject: Re: [Buildroot] [PATCH] package/picocom: bump to version 2024-07
Date: Thu, 1 Aug 2024 23:06:02 +0200	[thread overview]
Message-ID: <20240801230602.11eaef15@windsurf> (raw)
In-Reply-To: <bb3ab486ff7b0113e36b555f9fdbd850c4d132a8.1722516057.git.baruch@tkos.co.il>

On Thu,  1 Aug 2024 15:40:57 +0300
Baruch Siach via buildroot <buildroot@buildroot.org> wrote:

> This release adds support for no-MMU build.
> 
> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  package/picocom/picocom.hash | 2 +-
>  package/picocom/picocom.mk   | 9 +++++++--
>  2 files changed, 8 insertions(+), 3 deletions(-)

I think you had forgotten the change in package/picocom/Config.in to
actually make the package available on !MMU platforms, so I did it when
applying.

>  define PICOCOM_BUILD_CMDS
> -	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)
> +	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) \
> +		EXTRA_CPPFLAGS='$(PICOCOM_CPPFLAGS)' $(MAKE) -C $(@D)

Also I changed the single quotes here to double quotes, as we much more
commonly use double quotes.

Thanks a lot, patch applied!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2024-08-01 21:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-01 12:40 [Buildroot] [PATCH] package/picocom: bump to version 2024-07 Baruch Siach via buildroot
2024-08-01 21:06 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240801230602.11eaef15@windsurf \
    --to=buildroot@buildroot.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.