From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9B63C3DA64 for ; Fri, 2 Aug 2024 01:55:50 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.a=rsa-sha256 header.s=default header.b=xl0PXqUg; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4WZpnw74Fjz3dWg for ; Fri, 2 Aug 2024 11:55:48 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.a=rsa-sha256 header.s=default header.b=xl0PXqUg; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.alibaba.com (client-ip=115.124.30.133; helo=out30-133.freemail.mail.aliyun.com; envelope-from=hsiangkao@linux.alibaba.com; receiver=lists.ozlabs.org) Received: from out30-133.freemail.mail.aliyun.com (out30-133.freemail.mail.aliyun.com [115.124.30.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4WZpnn032Xz3dGt for ; Fri, 2 Aug 2024 11:55:38 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1722563734; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=lK6S7ivxGPqa/RvIpSfQPWa/3h8wWrw57OAeA8rJVOY=; b=xl0PXqUgvz0dNCoL8l95wY5hGJtPedXRleVTTT8CoKDFtsHV/5+I0u6fdULaV/mBrLxCISeKsWCbWHqIi8P8PRIsxI9UFAXfV/r4vyxAeaRJf8L09fS2GhEzesiGaJEvHhAAHWrWSpHc7hqzVS+SckJbHhfZkgzaWT25MrOWG3s= X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R981e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033045220184;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=2;SR=0;TI=SMTPD_---0WBvVr7j_1722563728; Received: from x31i01179.sqa.na131.tbsite.net(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0WBvVr7j_1722563728) by smtp.aliyun-inc.com; Fri, 02 Aug 2024 09:55:33 +0800 From: Gao Xiang To: linux-erofs@lists.ozlabs.org Subject: [PATCH 1/3] erofs-utils: fsck: fix fd leak on failure in erofs_extract_file() Date: Fri, 2 Aug 2024 09:55:25 +0800 Message-ID: <20240802015527.2113797-1-hsiangkao@linux.alibaba.com> X-Mailer: git-send-email 2.43.5 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gao Xiang Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" Ignore the return values as other close()s instead. Coverity-id: 502331 Signed-off-by: Gao Xiang --- fsck/main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fsck/main.c b/fsck/main.c index fb66967..bbef645 100644 --- a/fsck/main.c +++ b/fsck/main.c @@ -702,11 +702,9 @@ again: /* verify data chunk layout */ ret = erofs_verify_inode_data(inode, fd); + close(fd); if (ret) return ret; - - if (close(fd)) - return -errno; return ret; } -- 2.43.5