From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Robert Marko <robimarko@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/mdio-tools: enable CONFIG_NETDEVICES
Date: Fri, 2 Aug 2024 18:35:49 +0200 [thread overview]
Message-ID: <20240802183549.170a5c4e@windsurf> (raw)
In-Reply-To: <20240802104437.488091-1-robimarko@gmail.com>
On Fri, 2 Aug 2024 12:44:37 +0200
Robert Marko <robimarko@gmail.com> wrote:
> mdio-tools depends on CONFIG_MDIO_DEVICE in order for mdiobus driver to
> be built, but CONFIG_MDIO_DEVICE depends on CONFIG_NETDEVICES which we
> are not enabling so on platforms without it enabled in kernel config
> building mdio-tools will fail with:
>
> ERROR: modpost: "mdio_find_bus" [output-1/build/mdio-tools-1.3.1/kernel/mdio-netlink.ko] undefined!
> ERROR: modpost: "__mdiobus_c45_read" [output-1/build/mdio-tools-1.3.1/kernel/mdio-netlink.ko] undefined!
> ERROR: modpost: "__mdiobus_read" [output-1/build/mdio-tools-1.3.1/kernel/mdio-netlink.ko] undefined!
> ERROR: modpost: "__mdiobus_c45_write" [output-1/build/mdio-tools-1.3.1/kernel/mdio-netlink.ko] undefined!
> ERROR: modpost: "__mdiobus_write" [output-1/build/mdio-tools-1.3.1/kernel/mdio-netlink.ko] undefined!
>
> So enable CONFIG_NETDEVICES as well to make sure CONFIG_MDIO_DEVICE can be enabled.
>
> Fixes: http://autobuild.buildroot.net/results/edf47df96cde6094c890c0b74034cced90335a39/
>
> Signed-off-by: Robert Marko <robimarko@gmail.com>
> ---
> package/mdio-tools/mdio-tools.mk | 1 +
> 1 file changed, 1 insertion(+)
Applied to master, thanks a lot for this fix!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-08-02 16:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-02 10:44 [Buildroot] [PATCH 1/1] package/mdio-tools: enable CONFIG_NETDEVICES Robert Marko
2024-08-02 16:35 ` Thomas Petazzoni via buildroot [this message]
2024-09-03 16:18 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240802183549.170a5c4e@windsurf \
--to=buildroot@buildroot.org \
--cc=robimarko@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.