From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Thomas Petazzoni via buildroot <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH 1/1] package/ebtables: fix build with gcc >= 14
Date: Fri, 2 Aug 2024 19:20:13 +0200 [thread overview]
Message-ID: <20240802192013.03f7639a@windsurf> (raw)
In-Reply-To: <20240724182838.4a9f1524@windsurf>
Hello Fabrice,
Any feedback to my review on this patch (this e-mail, and the other
reply to your patch) ? This would allow to move forward with merging
this fix. Thanks a lot!
Thomas
On Wed, 24 Jul 2024 18:28:38 +0200
Thomas Petazzoni via buildroot <buildroot@buildroot.org> wrote:
> Hello Fabrice,
>
> Thanks for looking into this, it looks complicated. Question below.
>
> On Wed, 24 Jul 2024 09:19:04 +0200
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>
> > diff --git a/package/ebtables/0003-configure.ac-add-option-enable-kernel-64-userland-32.patch b/package/ebtables/0002-configure.ac-add-option-enable-kernel-64-userland-32.patch
> > similarity index 85%
> > rename from package/ebtables/0003-configure.ac-add-option-enable-kernel-64-userland-32.patch
> > rename to package/ebtables/0002-configure.ac-add-option-enable-kernel-64-userland-32.patch
> > index cb57b39569..7e481606e7 100644
> > --- a/package/ebtables/0003-configure.ac-add-option-enable-kernel-64-userland-32.patch
> > +++ b/package/ebtables/0002-configure.ac-add-option-enable-kernel-64-userland-32.patch
>
> So why do we have that adds an option to enable kernel-64-userland-32, if...
>
> > -# for 0003-configure.ac-add-option-enable-kernel-64-userland-32.patch
> > +# for 0002-configure.ac-add-option-enable-kernel-64-userland-32.patch
> > EBTABLES_AUTORECONF = YES
> > -ifeq ($(BR2_KERNEL_64_USERLAND_32),y)
> > -EBTABLES_CONF_OPTS += --enable-kernel-64-userland-32
> > -endif
> > +# kernel-64-userland-32 is broken (spotted with gcc >= 14)
> > +EBTABLES_CONF_OPTS += --disable-kernel-64-userland-32
>
> ... we always disable it? Doesn't this make the patch entirely useless?
>
> Thanks,
>
> Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-08-02 17:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-24 7:19 [Buildroot] [PATCH 1/1] package/ebtables: fix build with gcc >= 14 Fabrice Fontaine
2024-07-24 16:28 ` Thomas Petazzoni via buildroot
2024-08-02 17:20 ` Thomas Petazzoni via buildroot [this message]
2024-07-24 16:29 ` Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240802192013.03f7639a@windsurf \
--to=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.