All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Anisse Astier <anisse@astier.eu>,
	Christian Stewart <christian@aperture.us>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/pkg-golang.mk: allow packages to override download GOPROXY
Date: Fri, 2 Aug 2024 23:39:08 +0200	[thread overview]
Message-ID: <20240802233908.6e7a3dfa@windsurf> (raw)
In-Reply-To: <20240719030537.3156999-1-james.hilliard1@gmail.com>

On Thu, 18 Jul 2024 21:05:36 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:

> Some packages like the upcoming tailscale package need to set GOPROXY
> to get the correct dependencies.
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>  package/pkg-golang.mk | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Considering the feedback from Christian on this PATCH 1/2, I have
marked the series as Changes Requested. Could you resend once the
vendoring issue is resolved?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2024-08-02 21:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-19  3:05 [Buildroot] [PATCH 1/2] package/pkg-golang.mk: allow packages to override download GOPROXY James Hilliard
2024-07-19  3:05 ` [Buildroot] [PATCH 2/2] package/tailscale: new package James Hilliard
2024-07-19  3:26   ` Christian Stewart via buildroot
2024-07-19  3:26 ` [Buildroot] [PATCH 1/2] package/pkg-golang.mk: allow packages to override download GOPROXY Christian Stewart via buildroot
2024-07-19  3:37   ` James Hilliard
2024-07-19  4:23     ` Christian Stewart via buildroot
2024-08-02 21:39 ` Thomas Petazzoni via buildroot [this message]
2024-08-02 21:40   ` Thomas Petazzoni via buildroot
  -- strict thread matches above, loose matches on Subject: below --
2024-10-23 17:36 James Hilliard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240802233908.6e7a3dfa@windsurf \
    --to=buildroot@buildroot.org \
    --cc=anisse@astier.eu \
    --cc=christian@aperture.us \
    --cc=james.hilliard1@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.