From: kernel test robot <lkp@intel.com>
To: Isaku Yamahata <isaku.yamahata@intel.com>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
Kai Huang <kai.huang@intel.com>, Yan Zhao <yan.y.zhao@intel.com>
Subject: [intel-tdx:tdx_kvm_dev-2024-08-01-rebase 66/152] arch/x86/kvm/vmx/main.c:34:14: error: expression is not assignable
Date: Sat, 3 Aug 2024 14:41:42 +0800 [thread overview]
Message-ID: <202408031457.OSm7ShBY-lkp@intel.com> (raw)
tree: https://github.com/intel/tdx.git tdx_kvm_dev-2024-08-01-rebase
head: 5c43d1421f84cdeb3172f10826e98cbb920657fa
commit: 9cf78ea6bd2d11c2f86e94a416ddcf6797a60602 [66/152] With fixup: KVM: TDX: TDP MMU TDX support
config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20240803/202408031457.OSm7ShBY-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240803/202408031457.OSm7ShBY-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408031457.OSm7ShBY-lkp@intel.com/
All errors (new ones prefixed by >>):
>> arch/x86/kvm/vmx/main.c:34:14: error: expression is not assignable
34 | enable_tdx = false;
| ~~~~~~~~~~ ^
1 error generated.
vim +34 arch/x86/kvm/vmx/main.c
17
18 static __init int vt_hardware_setup(void)
19 {
20 int ret;
21
22 ret = vmx_hardware_setup();
23 if (ret)
24 return ret;
25
26 #if IS_ENABLED(CONFIG_HYPERV)
27 /*
28 * TDX KVM overrides flush_remote_tlbs method and assumes
29 * flush_remote_tlbs_range = NULL that falls back to
30 * flush_remote_tlbs. Disable TDX if there are conflicts.
31 */
32 if (vt_x86_ops.flush_remote_tlbs ||
33 vt_x86_ops.flush_remote_tlbs_range) {
> 34 enable_tdx = false;
35 pr_warn_ratelimited("TDX requires baremetal. Not Supported on VMM guest.\n");
36 }
37 #endif
38
39 /*
40 * Undate vt_x86_ops::vm_size here so it is ready before
41 * kvm_ops_update() is called in kvm_x86_vendor_init().
42 *
43 * Note, the actual bringing up of TDX must be done after
44 * kvm_ops_update() because enabling TDX requires enabling
45 * hardware virtualization first, i.e., all online CPUs must
46 * be in post-VMXON state. This means the @vm_size here
47 * may be updated to TDX's size but TDX may fail to enable
48 * at later time.
49 *
50 * The VMX/VT code could update kvm_x86_ops::vm_size again
51 * after bringing up TDX, but this would require exporting
52 * either kvm_x86_ops or kvm_ops_update() from the base KVM
53 * module, which looks overkill. Anyway, the worst case here
54 * is KVM may allocate couple of more bytes than needed for
55 * each VM.
56 */
57 if (enable_tdx) {
58 vt_x86_ops.vm_size = max_t(unsigned int, vt_x86_ops.vm_size,
59 sizeof(struct kvm_tdx));
60 /*
61 * Note, TDX may fail to initialize in a later time in
62 * vt_init(), in which case it is not necessary to setup
63 * those callbacks. But making them valid here even
64 * when TDX fails to init later is fine because those
65 * callbacks won't be called if the VM isn't TDX guest.
66 */
67 vt_x86_ops.link_external_spt = tdx_sept_link_private_spt;
68 vt_x86_ops.set_external_spte = tdx_sept_set_private_spte;
69 vt_x86_ops.free_external_spt = tdx_sept_free_private_spt;
70 vt_x86_ops.remove_external_spte = tdx_sept_remove_private_spte;
71 }
72
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2024-08-03 6:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202408031457.OSm7ShBY-lkp@intel.com \
--to=lkp@intel.com \
--cc=isaku.yamahata@intel.com \
--cc=kai.huang@intel.com \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=yan.y.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.