Re: [Buildroot] [PATCH 7/8] configs/nitrogen8ulp: new defconfig

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Chris Dimich <cdimich2188@gmail.com>
Cc: Gary Bisson <bisson.gary@gmail.com>,
	Refik Tuzakli <tuzakli.refik@gmail.com>,
	buildroot@buildroot.org, Romain Naour <romain.naour@gmail.com>,
	Giulio Benetti <giulio.benetti@benettiengineering.com>,
	Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
Subject: Re: [Buildroot] [PATCH 7/8] configs/nitrogen8ulp: new defconfig
Date: Sat, 3 Aug 2024 20:23:46 +0200	[thread overview]
Message-ID: <20240803202346.31a0626d@windsurf> (raw)
In-Reply-To: <20240611180207.2138847-8-cdimich2188@gmail.com>

Hello Chris,

On Tue, 11 Jun 2024 11:02:06 -0700
Chris Dimich <cdimich2188@gmail.com> wrote:

> More details on the platform here:
> 
> https://www.ezurio.com/system-on-module/nxp-imx8/nitrogen8ulp-som
> 
> Signed-off-by: Chris Dimich <cdimich2188@gmail.com>
> ---
>  configs/nitrogen8ulp_defconfig | 63 ++++++++++++++++++++++++++++++++++
>  1 file changed, 63 insertions(+)

Thanks for the patch! A new defconfig can never be standalone, it at
very least needs:

 - An entry in the DEVELOPERS file

 - A readme.txt (either for the board, or a common one, like
   board/boundarydevices/common/readme.txt)

> diff --git a/configs/nitrogen8ulp_defconfig b/configs/nitrogen8ulp_defconfig
> new file mode 100644
> index 0000000000..4ce6c29387
> --- /dev/null
> +++ b/configs/nitrogen8ulp_defconfig
> @@ -0,0 +1,63 @@
> +# Architecture
> +BR2_aarch64=y
> +BR2_cortex_a35=y
> +
> +# System
> +BR2_SSP_NONE=y

Please do not disable SSP, there's I believe no reason to do so.

Also, for new defconfigs, we require BR2_DOWNLOAD_FORCE_CHECK_HASHES=y
to be enabled. ./utils/add-custom-hashes can help you to generate those
hashes.

> +# ARM Trusted Firmware
> +BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_TARBALL=y
> +# Latest revision of branch boundary-lf-6.1.55-2.0.0
> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_TARBALL_LOCATION="https://github.com/boundarydevices/imx-atf/archive/d18357b7.tar.gz"

Maybe we could do instead:

$(call github,boundarydevices,imx-atf,d18357b7)/imx-atf-d18357b7.tar.gz ?

and ditto for others? (This is not a strong requirement, but we do this
in other defconfigs).

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot