Fwd: Re: [sj:damon/next 36/44] mm/damon/vaddr.c:311:22: error: implicit declaration of function 'pmd_present'; did you mean 'p4d_present'?

[SeongJae Park <sj@kernel.org>]

Forwarding below to DAMON mailing list for future references.

=== >8 ===
From: SeongJae Park <sj@kernel.org>
To: kernel test robot <lkp@intel.com>
CC: SeongJae Park <sj@kernel.org>, oe-kbuild-all@lists.linux.dev
Subject: Re: [sj:damon/next 36/44] mm/damon/vaddr.c:311:22: error: implicit declaration of function 'pmd_present'; did you mean 'p4d_present'?
Message-Id: <20240804185944.92344-1-sj@kernel.org>
In-Reply-To: <202408040440.Oe31R40L-lkp@intel.com>
Date: Sun,  4 Aug 2024 11:59:44 -0700
Local-Date: 2024-08-04 11:59:44-07:00

Hi robot,

On Sun, 4 Aug 2024 04:54:56 +0800 kernel test robot <lkp@intel.com> wrote:

> Hi SeongJae,
> 
> First bad commit (maybe != root cause):
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git damon/next
> head:   fec73193b080d068291509554d3e4b21622ede2d
> commit: 069dc62c4181e3c1a10fa833c176b52765c05564 [36/44] mm/damon/Kconfig: select DAMON modules to test when test config is set
> config: arm-randconfig-001-20240804 (https://download.01.org/0day-ci/archive/20240804/202408040440.Oe31R40L-lkp@intel.com/config)
> compiler: arm-linux-gnueabi-gcc (GCC) 14.1.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240804/202408040440.Oe31R40L-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202408040440.Oe31R40L-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>    mm/damon/vaddr.c: In function 'damon_mkold_pmd_entry':
>    mm/damon/vaddr.c:307:13: error: implicit declaration of function 'pmd_trans_huge'; did you mean 'pmd_trans_huge_lock'? [-Wimplicit-function-declaration]
>      307 |         if (pmd_trans_huge(pmdp_get(pmd))) {
>          |             ^~~~~~~~~~~~~~
>          |             pmd_trans_huge_lock

Thank you for this report.  This specific issue can be fixed by making
DAMON_VADDR_KUNIT_TEST depends on MMU, or select MMU.  However, I think this
might be abusing the 'select' too much.

I'll revert[1] the commit and consider adding '.kunitconfig' file for DAMON kunit
tests, like others.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/sj/damon-hack.git/commit/?id=ef79e03b2a6355bd234cf611e5ad55f4f379fbc9


Thanks,
SJ

[...]