From: Al Viro <viro@zeniv.linux.org.uk>
To: Phillip Lougher <phillip@squashfs.org.uk>
Cc: Lizhi Xu <lizhi.xu@windriver.com>,
brauner@kernel.org, jack@suse.cz, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org,
squashfs-devel@lists.sourceforge.net,
syzbot+24ac24ff58dc5b0d26b9@syzkaller.appspotmail.com,
syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH V7] squashfs: Add symlink size check in squash_read_inode
Date: Sun, 4 Aug 2024 22:20:34 +0100 [thread overview]
Message-ID: <20240804212034.GE5334@ZenIV> (raw)
In-Reply-To: <ee839d00-fd42-4b69-951d-8571140c077b@squashfs.org.uk>
On Sun, Aug 04, 2024 at 10:16:05PM +0100, Phillip Lougher wrote:
> NACK. I see no reason to introduce an intermediate variable here.
>
> Please do what Al Viro suggested.
Alternatively, just check ->i_size after assignment. loff_t is
always a 64bit signed; le32_to_cpu() returns 32bit unsigned.
Conversion from u32 to s64 is always going to yield a non-negative
result; comparison with PAGE_SIZE is all you need there.
next prev parent reply other threads:[~2024-08-04 21:20 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 8:12 [syzbot] [squashfs?] KMSAN: uninit-value in pick_link syzbot
2024-08-01 1:23 ` [syzbot] " syzbot
2024-08-01 2:27 ` [PATCH] filemap: Init the newly allocated folio memory to 0 for the filemap Lizhi Xu
2024-08-01 2:58 ` Al Viro
2024-08-01 5:28 ` Lizhi Xu
2024-08-01 7:10 ` Al Viro
2024-08-01 7:24 ` Al Viro
2024-08-01 8:12 ` Lizhi Xu
2024-08-01 9:13 ` Lizhi Xu
2024-08-01 12:42 ` Al Viro
2024-08-01 15:17 ` [PATCH V2] squashfs: Add length check in squashfs_symlink_read_folio Lizhi Xu
2024-08-01 15:30 ` Jan Kara
2024-08-02 1:39 ` Lizhi Xu
2024-08-02 1:50 ` [PATCH V3] squashfs: Add i_size check in squash_read_inode Lizhi Xu
2024-08-02 3:01 ` [PATCH V4] " Lizhi Xu
2024-08-02 9:33 ` Jan Kara
2024-08-02 11:16 ` [PATCH V5] " Lizhi Xu
2024-08-02 13:52 ` Al Viro
2024-08-02 14:44 ` [PATCH] filemap: Init the newly allocated folio memory to 0 for the filemap Lizhi Xu
2024-08-02 15:03 ` Al Viro
2024-08-03 4:07 ` [PATCH V6] squashfs: Add symlink size check in squash_read_inode Lizhi Xu
2024-08-03 7:43 ` [PATCH V7] " Lizhi Xu
2024-08-04 21:16 ` Phillip Lougher
2024-08-04 21:20 ` Al Viro [this message]
2024-08-04 22:31 ` Phillip Lougher
2024-08-05 7:03 ` Christian Brauner
2024-08-05 1:02 ` Lizhi Xu
2024-08-05 1:40 ` Al Viro
2024-08-06 2:56 ` Lizhi Xu
2024-08-06 4:59 ` Al Viro
2024-08-06 6:19 ` Lizhi Xu
2024-08-06 6:58 ` Al Viro
2024-08-01 9:07 ` [syzbot] Re: [syzbot] [squashfs?] KMSAN: uninit-value in pick_link syzbot
2024-08-01 9:27 ` syzbot
2024-08-01 12:08 ` syzbot
2024-08-01 13:06 ` syzbot
2024-08-01 14:08 ` syzbot
2024-08-01 14:39 ` syzbot
2024-08-02 1:02 ` syzbot
2024-08-02 2:00 ` syzbot
2024-08-03 3:04 ` syzbot
2024-08-03 3:13 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240804212034.GE5334@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizhi.xu@windriver.com \
--cc=phillip@squashfs.org.uk \
--cc=squashfs-devel@lists.sourceforge.net \
--cc=syzbot+24ac24ff58dc5b0d26b9@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.