From: Jason Wang <jasowang@redhat.com>
To: mst@redhat.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com,
eperezma@redhat.com
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, virtualization@lists.linux.dev,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH V5 net-next 0/3] virtio-net: synchronize op/admin state
Date: Mon, 5 Aug 2024 11:02:39 +0800 [thread overview]
Message-ID: <20240805030242.62390-1-jasowang@redhat.com> (raw)
Hi All:
This series tries to synchronize the operstate with the admin state
which allows the lower virtio-net to propagate the link status to the
upper devices like macvlan.
This is done by toggling carrier during ndo_open/stop while doing
other necessary serialization about the carrier settings during probe.
Changes since V4:
- do not update settings during ndo_open()
- do not try to canel config noticiation during probe() as core make
sure the config notificaiton won't be triggered before probe is
done.
- Tweak sevreal comments.
Changes since V3:
- when driver tries to enable config interrupt, check pending
interrupt and execute the nofitication change callback if necessary
- do not unconditonally trigger the config space read
- do not set LINK_UP flag in ndo_open/close but depends on the
notification change
- disable config change notification until ndo_open()
- read the link status under the rtnl_lock() to prevent a race with
ndo_open()
Changes since V2:
- introduce config_driver_disabled and helpers
- schedule config change work unconditionally
Jason Wang (3):
virtio: rename virtio_config_enabled to virtio_config_core_enabled
virtio: allow driver to disable the configure change notification
virtio-net: synchronize operstate with admin state on up/down
drivers/net/virtio_net.c | 78 +++++++++++++++++++++++++---------------
drivers/virtio/virtio.c | 59 +++++++++++++++++++++++-------
include/linux/virtio.h | 11 ++++--
3 files changed, 105 insertions(+), 43 deletions(-)
--
2.31.1
next reply other threads:[~2024-08-05 3:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-05 3:02 Jason Wang [this message]
2024-08-05 3:02 ` [PATCH V5 net-next 1/3] virtio: rename virtio_config_enabled to virtio_config_core_enabled Jason Wang
2024-08-05 3:02 ` [PATCH V5 net-next 2/3] virtio: allow driver to disable the configure change notification Jason Wang
2024-08-05 3:02 ` [PATCH V5 net-next 3/3] virtio-net: synchronize operstate with admin state on up/down Jason Wang
2024-08-05 5:52 ` Michael S. Tsirkin
2024-08-05 6:16 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240805030242.62390-1-jasowang@redhat.com \
--to=jasowang@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.