From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Clark Williams <williams@redhat.com>
Cc: stable-rt <stable-rt@vger.kernel.org>, "Claudio R.,
Luis" <lgoncalv@redhat.com>
Subject: Re: CI build failure in v6.6-rt
Date: Mon, 5 Aug 2024 13:00:00 +0200 [thread overview]
Message-ID: <20240805110000.ga17k3zy@linutronix.de> (raw)
In-Reply-To: <20240805105834.9GZL-G9o@linutronix.de>
On 2024-08-05 12:58:36 [+0200], To Kroah-Hartman, Greg wrote:
> I'm sorry. I misunderstood Clark and assumed this is a stable issue. Now
> that I have the needed pointers, it is a RT-stable issue only.
> I'm going to drop the stable folks from Cc: and reply with a patch.
>
Clark, this one, please:
----->8------
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Date: Mon, 5 Aug 2024 12:38:59 +0200
Subject: [PATCH] riscv: Add return value to check_unaligned_access().
The stable backport of commit c20d36cc2a207 ("riscv: don't probe
unaligned access speed if already done") added a `return' stament to
check_unaligned_access(). The return value of the function is `void' but
the RT tree has the backport of commit 73cf6167ef44c ("RISC-V: Probe
misaligned access speed in parallel") which changes the return type to
`int'.
Make the return statement return 0.
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
arch/riscv/kernel/cpufeature.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/riscv/kernel/cpufeature.c b/arch/riscv/kernel/cpufeature.c
index dd118773e717b..347cdf56f3a15 100644
--- a/arch/riscv/kernel/cpufeature.c
+++ b/arch/riscv/kernel/cpufeature.c
@@ -588,7 +588,7 @@ static int check_unaligned_access(void *param)
/* We are already set since the last check */
if (per_cpu(misaligned_access_speed, cpu) != RISCV_HWPROBE_MISALIGNED_UNKNOWN)
- return;
+ return 0;
/* Make an unaligned destination buffer. */
dst = (void *)((unsigned long)page_address(page) | 0x1);
--
2.45.2
Sebastian
next prev parent reply other threads:[~2024-08-05 11:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-02 20:46 CI build failure in v6.6-rt Clark Williams
2024-08-03 6:20 ` Kroah-Hartman, Greg
2024-08-05 10:58 ` Sebastian Andrzej Siewior
2024-08-05 11:00 ` Sebastian Andrzej Siewior [this message]
2024-08-05 15:09 ` Clark Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240805110000.ga17k3zy@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=lgoncalv@redhat.com \
--cc=stable-rt@vger.kernel.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.