From: kernel test robot <lkp@intel.com>
To: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>, gregkh@linuxfoundation.org
Cc: oe-kbuild-all@lists.linux.dev, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Subject: Re: [PATCH 05/13] serial: use guards for simple mutex locks
Date: Tue, 6 Aug 2024 02:09:32 +0800 [thread overview]
Message-ID: <202408060140.glPvoH1S-lkp@intel.com> (raw)
In-Reply-To: <20240805102046.307511-6-jirislaby@kernel.org>
Hi Jiri,
kernel test robot noticed the following build errors:
[auto build test ERROR on tty/tty-testing]
[also build test ERROR on tty/tty-next tty/tty-linus usb/usb-testing usb/usb-next usb/usb-linus linus/master v6.11-rc2 next-20240805]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Jiri-Slaby-SUSE/tty-simplify-tty_dev_name_to_number-using-guard-mutex/20240805-184227
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
patch link: https://lore.kernel.org/r/20240805102046.307511-6-jirislaby%40kernel.org
patch subject: [PATCH 05/13] serial: use guards for simple mutex locks
config: openrisc-defconfig (https://download.01.org/0day-ci/archive/20240806/202408060140.glPvoH1S-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240806/202408060140.glPvoH1S-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408060140.glPvoH1S-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/tty/serial/serial_core.c: In function 'uart_suspend_port':
>> drivers/tty/serial/serial_core.c:2400:17: error: label 'unlock' used but not defined
2400 | goto unlock;
| ^~~~
vim +/unlock +2400 drivers/tty/serial/serial_core.c
b3b708fa2780cd drivers/serial/serial_core.c Guennadi Liakhovetski 2007-10-16 2369
ccce6debb62d94 drivers/serial/serial_core.c Alan Cox 2009-09-19 2370 int uart_suspend_port(struct uart_driver *drv, struct uart_port *uport)
^1da177e4c3f41 drivers/serial/serial_core.c Linus Torvalds 2005-04-16 2371 {
ccce6debb62d94 drivers/serial/serial_core.c Alan Cox 2009-09-19 2372 struct uart_state *state = drv->state + uport->line;
ccce6debb62d94 drivers/serial/serial_core.c Alan Cox 2009-09-19 2373 struct tty_port *port = &state->port;
b3b708fa2780cd drivers/serial/serial_core.c Guennadi Liakhovetski 2007-10-16 2374 struct device *tty_dev;
ccce6debb62d94 drivers/serial/serial_core.c Alan Cox 2009-09-19 2375 struct uart_match match = {uport, drv};
^1da177e4c3f41 drivers/serial/serial_core.c Linus Torvalds 2005-04-16 2376
d2d8bbc5cc74b7 drivers/tty/serial/serial_core.c Jiri Slaby (SUSE 2024-08-05 2377) guard(mutex)(&port->mutex);
^1da177e4c3f41 drivers/serial/serial_core.c Linus Torvalds 2005-04-16 2378
b286f4e87e325b drivers/tty/serial/serial_core.c Tony Lindgren 2023-11-13 2379 tty_dev = device_find_child(&uport->port_dev->dev, &match, serial_match_port);
88e2582e90bb89 drivers/tty/serial/serial_core.c Lucas Stach 2017-05-11 2380 if (tty_dev && device_may_wakeup(tty_dev)) {
aef3ad103a686f drivers/tty/serial/serial_core.c Andy Shevchenko 2017-08-13 2381 enable_irq_wake(uport->irq);
b3b708fa2780cd drivers/serial/serial_core.c Guennadi Liakhovetski 2007-10-16 2382 put_device(tty_dev);
b3b708fa2780cd drivers/serial/serial_core.c Guennadi Liakhovetski 2007-10-16 2383 return 0;
b3b708fa2780cd drivers/serial/serial_core.c Guennadi Liakhovetski 2007-10-16 2384 }
5a65dcc04cda41 drivers/tty/serial/serial_core.c Federico Vaga 2013-04-15 2385 put_device(tty_dev);
5a65dcc04cda41 drivers/tty/serial/serial_core.c Federico Vaga 2013-04-15 2386
c9d2325cdb92fd drivers/tty/serial/serial_core.c Vijaya Krishna Nivarthi 2022-05-16 2387 /*
c9d2325cdb92fd drivers/tty/serial/serial_core.c Vijaya Krishna Nivarthi 2022-05-16 2388 * Nothing to do if the console is not suspending
c9d2325cdb92fd drivers/tty/serial/serial_core.c Vijaya Krishna Nivarthi 2022-05-16 2389 * except stop_rx to prevent any asynchronous data
cfab87c2c27157 drivers/tty/serial/serial_core.c Vijaya Krishna Nivarthi 2022-06-08 2390 * over RX line. However ensure that we will be
cfab87c2c27157 drivers/tty/serial/serial_core.c Vijaya Krishna Nivarthi 2022-06-08 2391 * able to Re-start_rx later.
c9d2325cdb92fd drivers/tty/serial/serial_core.c Vijaya Krishna Nivarthi 2022-05-16 2392 */
c9d2325cdb92fd drivers/tty/serial/serial_core.c Vijaya Krishna Nivarthi 2022-05-16 2393 if (!console_suspend_enabled && uart_console(uport)) {
abcb0cf1f5b2d9 drivers/tty/serial/serial_core.c John Ogness 2023-05-25 2394 if (uport->ops->start_rx) {
559c7ff4e32455 drivers/tty/serial/serial_core.c Thomas Gleixner 2023-09-14 2395 uart_port_lock_irq(uport);
c9d2325cdb92fd drivers/tty/serial/serial_core.c Vijaya Krishna Nivarthi 2022-05-16 2396 uport->ops->stop_rx(uport);
559c7ff4e32455 drivers/tty/serial/serial_core.c Thomas Gleixner 2023-09-14 2397 uart_port_unlock_irq(uport);
abcb0cf1f5b2d9 drivers/tty/serial/serial_core.c John Ogness 2023-05-25 2398 }
a47cf07f60dcb0 drivers/tty/serial/serial_core.c Claudiu Beznea 2024-04-30 2399 device_set_awake_path(uport->dev);
b164c9721e3ea4 drivers/tty/serial/serial_core.c Peter Hurley 2015-01-22 @2400 goto unlock;
c9d2325cdb92fd drivers/tty/serial/serial_core.c Vijaya Krishna Nivarthi 2022-05-16 2401 }
b164c9721e3ea4 drivers/tty/serial/serial_core.c Peter Hurley 2015-01-22 2402
ccce6debb62d94 drivers/serial/serial_core.c Alan Cox 2009-09-19 2403 uport->suspended = 1;
b3b708fa2780cd drivers/serial/serial_core.c Guennadi Liakhovetski 2007-10-16 2404
d41861ca19c9e9 drivers/tty/serial/serial_core.c Peter Hurley 2016-04-09 2405 if (tty_port_initialized(port)) {
ccce6debb62d94 drivers/serial/serial_core.c Alan Cox 2009-09-19 2406 const struct uart_ops *ops = uport->ops;
c8c6bfa39d6bd7 drivers/serial/serial_core.c Russell King 2008-02-04 2407 int tries;
18c9d4a3c249e9 drivers/tty/serial/serial_core.c Al Cooper 2022-03-24 2408 unsigned int mctrl;
^1da177e4c3f41 drivers/serial/serial_core.c Linus Torvalds 2005-04-16 2409
75b20a2ac425b9 drivers/tty/serial/serial_core.c Ilpo Järvinen 2023-01-17 2410 tty_port_set_suspended(port, true);
515be7baeddb04 drivers/tty/serial/serial_core.c Ilpo Järvinen 2023-01-17 2411 tty_port_set_initialized(port, false);
a6b93a90850881 drivers/serial/serial_core.c Russell King 2006-10-01 2412
559c7ff4e32455 drivers/tty/serial/serial_core.c Thomas Gleixner 2023-09-14 2413 uart_port_lock_irq(uport);
ccce6debb62d94 drivers/serial/serial_core.c Alan Cox 2009-09-19 2414 ops->stop_tx(uport);
7c7f9bc986e698 drivers/tty/serial/serial_core.c Lukas Wunner 2022-09-22 2415 if (!(uport->rs485.flags & SER_RS485_ENABLED))
ccce6debb62d94 drivers/serial/serial_core.c Alan Cox 2009-09-19 2416 ops->set_mctrl(uport, 0);
18c9d4a3c249e9 drivers/tty/serial/serial_core.c Al Cooper 2022-03-24 2417 /* save mctrl so it can be restored on resume */
18c9d4a3c249e9 drivers/tty/serial/serial_core.c Al Cooper 2022-03-24 2418 mctrl = uport->mctrl;
18c9d4a3c249e9 drivers/tty/serial/serial_core.c Al Cooper 2022-03-24 2419 uport->mctrl = 0;
ccce6debb62d94 drivers/serial/serial_core.c Alan Cox 2009-09-19 2420 ops->stop_rx(uport);
559c7ff4e32455 drivers/tty/serial/serial_core.c Thomas Gleixner 2023-09-14 2421 uart_port_unlock_irq(uport);
^1da177e4c3f41 drivers/serial/serial_core.c Linus Torvalds 2005-04-16 2422
^1da177e4c3f41 drivers/serial/serial_core.c Linus Torvalds 2005-04-16 2423 /*
^1da177e4c3f41 drivers/serial/serial_core.c Linus Torvalds 2005-04-16 2424 * Wait for the transmitter to empty.
^1da177e4c3f41 drivers/serial/serial_core.c Linus Torvalds 2005-04-16 2425 */
ccce6debb62d94 drivers/serial/serial_core.c Alan Cox 2009-09-19 2426 for (tries = 3; !ops->tx_empty(uport) && tries; tries--)
^1da177e4c3f41 drivers/serial/serial_core.c Linus Torvalds 2005-04-16 2427 msleep(10);
c8c6bfa39d6bd7 drivers/serial/serial_core.c Russell King 2008-02-04 2428 if (!tries)
cade3580f79aeb drivers/tty/serial/serial_core.c Andy Shevchenko 2017-03-31 2429 dev_err(uport->dev, "%s: Unable to drain transmitter\n",
cade3580f79aeb drivers/tty/serial/serial_core.c Andy Shevchenko 2017-03-31 2430 uport->name);
^1da177e4c3f41 drivers/serial/serial_core.c Linus Torvalds 2005-04-16 2431
ccce6debb62d94 drivers/serial/serial_core.c Alan Cox 2009-09-19 2432 ops->shutdown(uport);
18c9d4a3c249e9 drivers/tty/serial/serial_core.c Al Cooper 2022-03-24 2433 uport->mctrl = mctrl;
^1da177e4c3f41 drivers/serial/serial_core.c Linus Torvalds 2005-04-16 2434 }
^1da177e4c3f41 drivers/serial/serial_core.c Linus Torvalds 2005-04-16 2435
^1da177e4c3f41 drivers/serial/serial_core.c Linus Torvalds 2005-04-16 2436 /*
^1da177e4c3f41 drivers/serial/serial_core.c Linus Torvalds 2005-04-16 2437 * Disable the console device before suspending.
^1da177e4c3f41 drivers/serial/serial_core.c Linus Torvalds 2005-04-16 2438 */
b164c9721e3ea4 drivers/tty/serial/serial_core.c Peter Hurley 2015-01-22 2439 if (uart_console(uport))
ccce6debb62d94 drivers/serial/serial_core.c Alan Cox 2009-09-19 2440 console_stop(uport->cons);
^1da177e4c3f41 drivers/serial/serial_core.c Linus Torvalds 2005-04-16 2441
6f538fe31c1d45 drivers/tty/serial/serial_core.c Linus Walleij 2012-12-07 2442 uart_change_pm(state, UART_PM_STATE_OFF);
^1da177e4c3f41 drivers/serial/serial_core.c Linus Torvalds 2005-04-16 2443
^1da177e4c3f41 drivers/serial/serial_core.c Linus Torvalds 2005-04-16 2444 return 0;
^1da177e4c3f41 drivers/serial/serial_core.c Linus Torvalds 2005-04-16 2445 }
15dc475bcc1739 drivers/tty/serial/serial_core.c Jiri Slaby 2022-01-24 2446 EXPORT_SYMBOL(uart_suspend_port);
^1da177e4c3f41 drivers/serial/serial_core.c Linus Torvalds 2005-04-16 2447
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-08-05 18:10 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-05 10:20 [PATCH 00/13] tty: random fixes and cleanups Jiri Slaby (SUSE)
2024-08-05 10:20 ` [PATCH 01/13] tty: simplify tty_dev_name_to_number() using guard(mutex) Jiri Slaby (SUSE)
2024-08-05 14:25 ` Ilpo Järvinen
2024-08-05 10:20 ` [PATCH 02/13] serial: protect uart_port_dtr_rts() in uart_shutdown() too Jiri Slaby (SUSE)
2024-08-05 10:20 ` [PATCH 03/13] serial: don't use uninitialized value in uart_poll_init() Jiri Slaby (SUSE)
2024-08-05 14:28 ` Ilpo Järvinen
2024-08-05 15:46 ` Doug Anderson
2024-08-08 7:34 ` Jiri Slaby
2024-08-08 7:44 ` Greg Kroah-Hartman
2024-08-08 9:15 ` Ilpo Järvinen
2024-08-05 15:43 ` Doug Anderson
2024-08-05 10:20 ` [PATCH 04/13] serial: remove quot_frac from serial8250_do_set_divisor() Jiri Slaby (SUSE)
2024-08-05 10:20 ` [PATCH 05/13] serial: use guards for simple mutex locks Jiri Slaby (SUSE)
2024-08-05 17:57 ` kernel test robot
2024-08-05 18:09 ` kernel test robot [this message]
2024-08-07 11:15 ` Greg KH
2024-08-05 10:20 ` [PATCH 06/13] mxser: remove stale comment Jiri Slaby (SUSE)
2024-08-05 10:20 ` [PATCH 07/13] mxser: remove doubled sets of close times Jiri Slaby (SUSE)
2024-08-05 10:20 ` [PATCH 08/13] mctp: serial: propagage new tty types Jiri Slaby (SUSE)
2024-08-06 4:51 ` Jeremy Kerr
2024-08-08 10:35 ` Jiri Slaby
2024-08-05 10:20 ` [PATCH 09/13] 6pack: remove sixpack::rbuff Jiri Slaby (SUSE)
2024-08-05 10:20 ` [PATCH 10/13] 6pack: drop sixpack::mtu Jiri Slaby (SUSE)
2024-08-05 10:20 ` [PATCH 11/13] 6pack: drop sixpack::buffsize Jiri Slaby (SUSE)
2024-08-05 10:20 ` [PATCH 12/13] 6pack: remove global strings Jiri Slaby (SUSE)
2024-08-05 10:20 ` [PATCH 13/13] 6pack: propagage new tty types Jiri Slaby (SUSE)
2024-08-07 11:14 ` [PATCH 00/13] tty: random fixes and cleanups Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202408060140.glPvoH1S-lkp@intel.com \
--to=lkp@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.