From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CED45C49EA1 for ; Tue, 6 Aug 2024 14:55:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 8A18460829; Tue, 6 Aug 2024 14:55:42 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id oSp5F37ZqawY; Tue, 6 Aug 2024 14:55:42 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org E9359606F6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1722956142; bh=7O1jbdZoOQw4mZ0D87RSFQxcBqiSkgrwaQlgXEWUDvo=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=QEM5yF4UeKivlc3igklt/o4lXDcJ+BHI787BRDFmbdxF8aGLQAWN2jDsLwdMkz2Sf vlIhnjv7HwxSJ6j4qxeJ0MeqB0FJyYIb+SQ2vU9BdqzXt0Qj5iVRFSyD+/+C6Qc9IL E+cb7Ny/9Vfdhn/YzLC+U1KLKkjZNukGem3oHEmYaRCqb27B4hkbR01M6rxW8l0+t/ qV3hUNtG+p/7PLeQkVSOVPSZlsPwtMoA9svwOdjSbVQDTTY0nIuYYAW6iR/nc6dJXV Rq3tBrlSkACh6yko7Esb8N7+McJjisvHch5JM0CSLB0KNYN0nLz58jbHKJMvF5yrIL ihvixxyLtFxDQ== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id E9359606F6; Tue, 6 Aug 2024 14:55:41 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 9C76E1BF2B0 for ; Tue, 6 Aug 2024 14:55:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 89439606F6 for ; Tue, 6 Aug 2024 14:55:40 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id gU3L7tOM64Ta for ; Tue, 6 Aug 2024 14:55:40 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2604:1380:40e1:4800::1; helo=sin.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org B30CC606B4 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org B30CC606B4 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by smtp3.osuosl.org (Postfix) with ESMTPS id B30CC606B4 for ; Tue, 6 Aug 2024 14:55:39 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id D74EDCE0D85; Tue, 6 Aug 2024 14:55:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5DFD0C32786; Tue, 6 Aug 2024 14:55:33 +0000 (UTC) Date: Tue, 6 Aug 2024 15:55:31 +0100 From: Simon Horman To: Wojciech Drewek Message-ID: <20240806145531.GW2636630@kernel.org> References: <20240805124651.125761-1-wojciech.drewek@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240805124651.125761-1-wojciech.drewek@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722956135; bh=cfLjLzytKWxZNDBT4m7gnseD/sS6bz7gYmCdZFohyLA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FDZXQJSIGYVVpwQTZ6eVZDsGpKSOMYlMv8/2gUBTk+A7FVbFNoXJI5a4ZMaIW+HzQ 8Q3yZ/NxSuzxPma+I52OsJgvGn1qveWUa5rhMoPWyOOKCgMckGlYKNBl9cDCPy6UCS 4/K/dxOXj/yf4EMSNhfQa6mcVUI1UqVdfyOvr+dGoIED7XNPvHJUmeZvLg+PKTJyAx VmMDNPW1+bfXm5z1BLFkgefSYhh54Sj2/I0H4qnMSgxoMQhcSyHQnBqLYNvO4oXXAq xDDasvEzggZxCf0f6WhXYhY+vUzDXgONZnL/6va4jhQ2BIN3wQwNA4GxPHFIJOF7er HGXlfNEkCDOTg== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=none dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=FDZXQJSI Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2] ice: Implement ethtool reset support X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, edumazet@google.com, anthony.l.nguyen@intel.com, kuba@kernel.org, intel-wired-lan@lists.osuosl.org, pabeni@redhat.com, przemyslaw.kitszel@intel.com Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, Aug 05, 2024 at 02:46:51PM +0200, Wojciech Drewek wrote: > Enable ethtool reset support. Ethtool reset flags are mapped to the > E810 reset type: > PF reset: > $ ethtool --reset irq dma filter offload > CORE reset: > $ ethtool --reset irq-shared dma-shared filter-shared \ > offload-shared ram-shared > GLOBAL reset: > $ ethtool --reset irq-shared dma-shared filter-shared \ > offload-shared mac-shared phy-shared ram-shared > > Calling the same set of flags as in PF reset case on port representor > triggers VF reset. > > Reviewed-by: Michal Swiatkowski > Reviewed-by: Marcin Szycik > Signed-off-by: Wojciech Drewek > --- > .../device_drivers/ethernet/intel/ice.rst | 28 +++++++ > drivers/net/ethernet/intel/ice/ice_ethtool.c | 77 +++++++++++++++++++ > 2 files changed, 105 insertions(+) > > diff --git a/Documentation/networking/device_drivers/ethernet/intel/ice.rst b/Documentation/networking/device_drivers/ethernet/intel/ice.rst > index 934752f675ba..c043164bfacc 100644 > --- a/Documentation/networking/device_drivers/ethernet/intel/ice.rst > +++ b/Documentation/networking/device_drivers/ethernet/intel/ice.rst > @@ -102,6 +102,34 @@ rx_bytes as "X", then ethtool (hardware statistics) will display rx_bytes as > "X+40" (4 bytes CRC x 10 packets). > > > +ethtool reset > +------------- > +The driver supports 3 types of resets: > +- PF reset - resets only components associated with the given PF, does not > + impact other PFs > +- CORE reset - whole adapter is affected, reset all PFs > +- GLOBAL reset - same as CORE but mac and phy components are also reinitialized Hi Wojciech, I'm not sure, but I think that Sphinx wants blank likes between these list items. Flagged by make: htmldocs SPHINXDIRS=networking ... From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A3FC41C72 for ; Tue, 6 Aug 2024 14:55:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722956135; cv=none; b=KUh1xk3IvvGuuwQeoeL8eTITDH1dgrvAZ1UhS+NlUxuLWwwqIZAXvmOwDbWeJR9PX7f40SD2koc2710yajyyr1Av/4e5l1GgD4gzuE62+MOdrgjXpDQHNpjFkufCT3Y6YNn84ZufDEwWuvEsSWmJrKPLgxyvLWFwLhtcNqHYc5Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722956135; c=relaxed/simple; bh=cfLjLzytKWxZNDBT4m7gnseD/sS6bz7gYmCdZFohyLA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kWf3BOBM81RM53SpHMTdw4LncHukDccCNuLRdIarbpU4Dx+B80FYa7VH/QDngVdStZwwhTaM55Gc57h9DbLByFOHVi8fJ+L4JewT/inG98ksdw6xE1SkejoWpOMxjT5QGT+jziSydGKY6fh6GDCosFQp8Tv/oD+gmKSCvZvaJdU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FDZXQJSI; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FDZXQJSI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5DFD0C32786; Tue, 6 Aug 2024 14:55:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722956135; bh=cfLjLzytKWxZNDBT4m7gnseD/sS6bz7gYmCdZFohyLA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FDZXQJSIGYVVpwQTZ6eVZDsGpKSOMYlMv8/2gUBTk+A7FVbFNoXJI5a4ZMaIW+HzQ 8Q3yZ/NxSuzxPma+I52OsJgvGn1qveWUa5rhMoPWyOOKCgMckGlYKNBl9cDCPy6UCS 4/K/dxOXj/yf4EMSNhfQa6mcVUI1UqVdfyOvr+dGoIED7XNPvHJUmeZvLg+PKTJyAx VmMDNPW1+bfXm5z1BLFkgefSYhh54Sj2/I0H4qnMSgxoMQhcSyHQnBqLYNvO4oXXAq xDDasvEzggZxCf0f6WhXYhY+vUzDXgONZnL/6va4jhQ2BIN3wQwNA4GxPHFIJOF7er HGXlfNEkCDOTg== Date: Tue, 6 Aug 2024 15:55:31 +0100 From: Simon Horman To: Wojciech Drewek Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, przemyslaw.kitszel@intel.com Subject: Re: [PATCH iwl-next v2] ice: Implement ethtool reset support Message-ID: <20240806145531.GW2636630@kernel.org> References: <20240805124651.125761-1-wojciech.drewek@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240805124651.125761-1-wojciech.drewek@intel.com> On Mon, Aug 05, 2024 at 02:46:51PM +0200, Wojciech Drewek wrote: > Enable ethtool reset support. Ethtool reset flags are mapped to the > E810 reset type: > PF reset: > $ ethtool --reset irq dma filter offload > CORE reset: > $ ethtool --reset irq-shared dma-shared filter-shared \ > offload-shared ram-shared > GLOBAL reset: > $ ethtool --reset irq-shared dma-shared filter-shared \ > offload-shared mac-shared phy-shared ram-shared > > Calling the same set of flags as in PF reset case on port representor > triggers VF reset. > > Reviewed-by: Michal Swiatkowski > Reviewed-by: Marcin Szycik > Signed-off-by: Wojciech Drewek > --- > .../device_drivers/ethernet/intel/ice.rst | 28 +++++++ > drivers/net/ethernet/intel/ice/ice_ethtool.c | 77 +++++++++++++++++++ > 2 files changed, 105 insertions(+) > > diff --git a/Documentation/networking/device_drivers/ethernet/intel/ice.rst b/Documentation/networking/device_drivers/ethernet/intel/ice.rst > index 934752f675ba..c043164bfacc 100644 > --- a/Documentation/networking/device_drivers/ethernet/intel/ice.rst > +++ b/Documentation/networking/device_drivers/ethernet/intel/ice.rst > @@ -102,6 +102,34 @@ rx_bytes as "X", then ethtool (hardware statistics) will display rx_bytes as > "X+40" (4 bytes CRC x 10 packets). > > > +ethtool reset > +------------- > +The driver supports 3 types of resets: > +- PF reset - resets only components associated with the given PF, does not > + impact other PFs > +- CORE reset - whole adapter is affected, reset all PFs > +- GLOBAL reset - same as CORE but mac and phy components are also reinitialized Hi Wojciech, I'm not sure, but I think that Sphinx wants blank likes between these list items. Flagged by make: htmldocs SPHINXDIRS=networking ...