All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/htop: fix BR2_SHARED_STATIC_LIBS build
Date: Tue, 6 Aug 2024 22:23:08 +0200	[thread overview]
Message-ID: <20240806222308.2426b0dc@windsurf> (raw)
In-Reply-To: <20240204101140.1403357-1-fontaine.fabrice@gmail.com>

Hello Fabrice,

On Sun,  4 Feb 2024 11:11:40 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> With BR2_SHARED_STATIC_LIBS=y, the generic infrastructure adds a
> --enable-static flags causing htop to be built as a static binary.
> Adding a --disable-static reverts this. This will fix the following
> build failure with hwloc raised since bump to version 3.3.0 in commit
> 09243186df3168022f0b23b8a9677c6313033769 and
> https://github.com/htop-dev/htop/commit/c8a61850dd31ab64eb8ad83929ce86d2adbeb96c:

[...]

> 
> Fixes:
>  - http://autobuild.buildroot.org/results/04bd5633750ff5cef048ea78c9de043d3ffcfa32
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/htop/htop.mk | 7 +++++++
>  1 file changed, 7 insertions(+)

I was initially not sure about this fix, but in the end, I agree that
it's the right one, so I've applied, with a slightly better comment in
the .mk file.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2024-08-06 20:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-04 10:11 [Buildroot] [PATCH 1/1] package/htop: fix BR2_SHARED_STATIC_LIBS build Fabrice Fontaine
2024-08-06 20:23 ` Thomas Petazzoni via buildroot [this message]
2024-09-03 19:14 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240806222308.2426b0dc@windsurf \
    --to=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.