From: Jakub Kicinski <kuba@kernel.org>
To: Gal Pressman <gal@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Dragos Tatulea <dtatulea@nvidia.com>,
Jianbo Liu <jianbol@nvidia.com>
Subject: Re: [PATCH net] ethtool: Fix context creation with no parameters
Date: Wed, 7 Aug 2024 09:30:12 -0700 [thread overview]
Message-ID: <20240807093012.6bd154a7@kernel.org> (raw)
In-Reply-To: <e5a9000a-230e-4118-8628-b44b682c8d8d@nvidia.com>
On Wed, 7 Aug 2024 19:14:57 +0300 Gal Pressman wrote:
> > @@ -1372,14 +1372,15 @@ static noinline_for_stack int ethtool_set_rxfh(struct net_device *dev,
> > /* If either indir, hash key or function is valid, proceed further.
>
> This comment is wrong, the check doesn't really verify the hash function
> is valid. I'll remove it in my fix unless you have any objections.
>
> Not verifying the hash function is probably another bug, but it's too
> late to fix it at this point?
Let's do that separately in net-next?
Old ethtool had a bit of a "forward compatibility" mindset,
so it may have been intentional.
next prev parent reply other threads:[~2024-08-07 16:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-07 13:25 [PATCH net] ethtool: Fix context creation with no parameters Gal Pressman
2024-08-07 14:21 ` Jakub Kicinski
2024-08-07 14:38 ` Gal Pressman
2024-08-07 16:14 ` Gal Pressman
2024-08-07 16:30 ` Jakub Kicinski [this message]
2024-08-07 16:48 ` Gal Pressman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240807093012.6bd154a7@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=jianbol@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.