All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anatolij Gustschin <agust@denx.de>
To: Heiko Schocher <hs@denx.de>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
	Tom Rini <trini@konsulko.com>,
	Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
Subject: Re: [PATCH] driver: pwm: pwm-imx: fix probing on imx6
Date: Wed, 7 Aug 2024 11:28:09 +0200	[thread overview]
Message-ID: <20240807112809.04ec0809@crub> (raw)
In-Reply-To: <20240807085811.115732-1-hs@denx.de>

Hi Heiko,

On Wed,  7 Aug 2024 10:58:11 +0200
Heiko Schocher hs@denx.de wrote:

> U-Boot 2024.07 drops on aristainetos2 board the following
> warning:
> 
> 	Failed to enable per_clk
> 
> and bootlogo is not seen on LVDS display.
> 
> This patch uses old behaviour for systems without clock framework
> if CONFIG_CLK is not enabled.
> 
> Fixes: bfc778cb93a3 ("driver: pwm: pwm-imx: get and enable per/ipg clock using dm")
> 
> Signed-off-by: Heiko Schocher <hs@denx.de>
> ---
> 
>  drivers/pwm/pwm-imx.c | 56 ++++++++++++++++++++++++-------------------
>  1 file changed, 31 insertions(+), 25 deletions(-)
> 
> diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c
> index 8fbb40cc276..0237ee70977 100644
> --- a/drivers/pwm/pwm-imx.c
> +++ b/drivers/pwm/pwm-imx.c
> @@ -160,7 +160,11 @@ int pwm_dm_imx_get_parms(struct imx_pwm_priv *priv, int period_ns,
>  {
>  	unsigned long long c;
>  
> -	c = clk_get_rate(&priv->per_clk);
> +	if (IS_ENABLED(CONFIG_CLK))

Can we please use if (CONFIG_IS_ENABLED(CLK)) ? So it will also
work with SPL. Thanks!

--
Anatolij

  reply	other threads:[~2024-08-07  9:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-07  8:58 [PATCH] driver: pwm: pwm-imx: fix probing on imx6 Heiko Schocher
2024-08-07  9:28 ` Anatolij Gustschin [this message]
2024-08-07  9:34   ` Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240807112809.04ec0809@crub \
    --to=agust@denx.de \
    --cc=hs@denx.de \
    --cc=tommaso.merciai@amarulasolutions.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.