All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Waldemar Brodkorb <wbx@openadk.org>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/libjcat: fix linking, add missing intl library
Date: Wed, 7 Aug 2024 11:55:04 +0200	[thread overview]
Message-ID: <20240807115504.4042b701@windsurf> (raw)
In-Reply-To: <ZrL7Ovbl+xTX+KX/@waldemar-brodkorb.de>

Hello Waldemar,

On Wed, 7 Aug 2024 06:42:34 +0200
Waldemar Brodkorb <wbx@openadk.org> wrote:

> +ifneq ($(BR2_TOOLCHAIN_USES_GLIBC),y)
> +LIBJCAT_LDFLAGS += -lintl
> +endif

Thanks, but this is not the correct way to deal with libintl issues.
See the Buildroot manual
at https://buildroot.org/downloads/manual/manual.html#_gettext_integration_and_interaction_with_packages.
You need to use $(TARGET_NLS_DEPENDENCIES) and $(TARGET_NLS_LIBS) to
have a correct behavior in all situations.

You can grep for TARGET_NLS_DEPENDENCIES and TARGET_NLS_LIBS in other
packages to see how they are being used.

Could you look into this and send a v2?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2024-08-07  9:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-07  4:42 [Buildroot] [PATCH] package/libjcat: fix linking, add missing intl library Waldemar Brodkorb
2024-08-07  9:55 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240807115504.4042b701@windsurf \
    --to=buildroot@buildroot.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=wbx@openadk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.